Comment on attachment 8933635 [details] Bug 1422282 - Upgrade react-redux to v5.0.6 https://reviewboard.mozilla.org/r/204582/#review210190 Thanks for doing this mike ! I have some concerns about relying on npm, see my comments ::: devtools/client/shared/vendor/REACT_REDUX_UPGRADING.md:18 (Diff revision 1) > +``` > + > +## Building > + > +```bash > +npm install can't we handle this without installing an npm module ? ::: devtools/client/shared/vendor/REACT_REDUX_UPGRADING.md:19 (Diff revision 1) > + > +## Building > + > +```bash > +npm install > +cp dist/react-redux.js <gecko-dev>/devtools/client/shared/vendor/react-redux.js I guess this won't work if node is not on your PATH ? ::: devtools/client/shared/vendor/react-redux-post-upgrade.js:1 (Diff revision 1) > +#!/usr/bin/env node > + > +"use strict"; > + > +const replace = require("replace"); > + > +replace({ > + regex: "'react'", > + replacement: "'devtools/client/shared/vendor/react'", > + paths: ['react-redux.js'], > + recursive: true > +}); > + > +replace({ > + regex: "'redux'", > + replacement: "'devtools/client/shared/vendor/redux'", > + paths: ['react-redux.js'], > + recursive: true > +}); i think this could be done with a bash script so we don't rely on having node, nor on the replace module

Comment on attachment 8933635 [details] Bug 1422282 - Upgrade react-redux to v5.0.6 https://reviewboard.mozilla.org/r/204582/#review210190 > i think this could be done with a bash script so we don't rely on having node, nor on the replace module Lets keep it simple and have the dev update it... much simpler.

Comment on attachment 8933635 [details] Bug 1422282 - Upgrade react-redux to v5.0.6 https://reviewboard.mozilla.org/r/204582/#review210502

Pushed by mratcliffe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8ed94b47791c Upgrade react-redux to v5.0.6 r=nchevobbe