Closed
Bug 1422606
Opened 7 years ago
Closed 6 years ago
Mozregression GUI please add support for opening app with URL
Categories
(Testing :: mozregression, enhancement)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Matti, Assigned: Kwan, Mentored)
Details
(Whiteboard: [lang=python])
Attachments
(1 file)
(deleted),
text/x-github-pull-request
|
Details |
mozregression commandline supports the --arg switch which is really helpful if you want to test your builds with a testcase URL.
I'm surprised that the GUI version doesn't support this option or at least a way to open an URL with each tested build.
Comment 1•7 years ago
|
||
Seems like a reasonable feature request and shouldn't be that difficult to implement for someone with some python experience. I would make it an option on the "Basic configuration" panel in the GUI. I don't have time to give detailed instructions on how to do this, but I can review a properly implemented patch.
Source code for mozregression gui (and instructions on how to run) is here: https://github.com/mozilla/mozregression
When you've implemented your patch, create a pull request with the name "Bug 1422606 - Add support to launching Firefox with arguments to the GUI"
No need to ask if you can work on this, just post a comment in this bug saying that you are doing so.
Mentor: wlachance
Whiteboard: [good first bug][lang=python]
Comment 2•7 years ago
|
||
Hi, I'll be working on this.
Comment 3•7 years ago
|
||
I do not plan to be working on this in the near future.
Comment 4•7 years ago
|
||
I want to take up this bug.
I'm running macOS however, is the GUI available on my platform?
Flags: needinfo?(wlachance)
Comment 5•7 years ago
|
||
I am working on this bug.
Comment 6•7 years ago
|
||
(In reply to Vedant Chakravadhanula(:vedantc98) from comment #4)
> I want to take up this bug.
> I'm running macOS however, is the GUI available on my platform?
Hi Vedant, sorry for the somewhat late reply. Yes, it is possible to run the GUI on MacOS X, however I haven't done it myself so can't give good instructions (there are some in https://github.com/mozilla/mozregression/blob/master/gui/README.rst though). Maybe best to let Yash work on this, since he's already started.
If you're looking for something to work on, I would welcome any patches to make the MacOS X version of mozregression easier to install for users (e.g. figure out how to generate a dmg that people can download and then self-install). Feel free to contact me if you're interested in that!
Assignee: nobody → yashsrivastava3005
Flags: needinfo?(wlachance)
Comment 7•7 years ago
|
||
Hi William
Yes I would definitely like to work on that, is there a bug already open for it?
Please let me know how I would need to proceed. Thanks!
Comment 8•7 years ago
|
||
(In reply to Vedant Chakravadhanula(:vedantc98) from comment #7)
> Hi William
>
> Yes I would definitely like to work on that, is there a bug already open for
> it?
> Please let me know how I would need to proceed. Thanks!
Hi Vedant, see bug 1425102. It turns out that this is a bit more involved than I thought to implement properly, probably involving porting mozregression (and some of its mozbase deps) to python 3. If that is interesting to you though, feel free to have a look!
Comment 9•7 years ago
|
||
Until this is added to the UI, how can it be done with the configuration file? [1]
"Each option correspond to its command-line counter part (the long form, but without the first double dashes, --). They are described here." [2]
What corresponds to arg in the mozregression.cfg file? I've tried each of the following in turn at the top of the file; they've had no effect:
arg = -private-window
arg = "-private-window"
arguments = -private-window
arguments = "-private-window"
[1] https://mozilla.github.io/mozregression/documentation/configuration.html
[2] https://mozilla.github.io/mozregression/documentation/usage.html
Flags: needinfo?(wlachance)
Comment 10•7 years ago
|
||
(In reply to Gingerbread Man from comment #9)
> Until this is added to the UI, how can it be done with the configuration
> file? [1]
It cannot be currently done, I wrote up a tentative PR adding the functionality:
https://github.com/mozilla/mozregression/pull/483
Need to think for a bit on whether I should actually try to merge this, but I suspect I probably will.
Flags: needinfo?(wlachance)
Comment 11•7 years ago
|
||
(In reply to William Lachance (:wlach) (use needinfo!) from comment #10)
> (In reply to Gingerbread Man from comment #9)
> > Until this is added to the UI, how can it be done with the configuration
> > file? [1]
>
> It cannot be currently done, I wrote up a tentative PR adding the
> functionality:
>
> https://github.com/mozilla/mozregression/pull/483
>
> Need to think for a bit on whether I should actually try to merge this, but
> I suspect I probably will.
Update: merged the patch, it will be in the next release of mozregression, which I will upload momentarily.
This is more-or-less a dumb workaround, far more optimal would be if the gui supported this natively.
Comment 12•7 years ago
|
||
Hey,
Has this already been fixed on the gui as well?
Flags: needinfo?(wlachance)
Comment 13•7 years ago
|
||
(In reply to karmanya_kakkar from comment #12)
> Hey,
>
> Has this already been fixed on the gui as well?
No, you can set arguments with the configuration file (mozregression.cfg) now though, as described above. The relevant section is "cmdargs".
Flags: needinfo?(wlachance)
Updated•7 years ago
|
Assignee: yashsrivastava3005 → nobody
Comment 14•6 years ago
|
||
Hi,
I see that this issue is unassigned. I would like to work on it.
Thanks.
Flags: needinfo?(wlachance)
Comment 15•6 years ago
|
||
(In reply to rajalakshmi.v15 from comment #14)
> Hi,
>
> I see that this issue is unassigned. I would like to work on it.
>
> Thanks.
It's yours! As I said in comment 1, I'm not able to mentor this bug in depth or provide step-by-step instructions (as is normal for a good first bug), but am happy to review a patch.
Assignee: nobody → rajalakshmi.v15
Flags: needinfo?(wlachance)
Comment 16•6 years ago
|
||
Thanks.
I am having trouble setting up mozregression-gui. When I try to build it from source, it gives me an error at the cx-Freeze installation stage. On the other hand, it fails at 'redo' when I run check.py after extracting from the compressed source (mozregression-gui-0.9.23.tar.gz). Could I get more help on this issue?
Flags: needinfo?(wlachance)
Comment 17•6 years ago
|
||
I understand that you are unable to provide step by step instructions, but guidance of any sort would be highly appreciated :)
Comment 18•6 years ago
|
||
I started building from the 0.9.22 release since the latest one was giving me errors.
This is the error I am getting when I try run the command:
python check.py -G
(python check.py works fine)
'''
uic'ing mozregui/ui/single_build_selection.ui -> mozregui/ui/single_build_selection.py
ERROR: API 'QDate' has already been set to version 1
'''
Tried adding the lines:
import sip
sip.setapi('QDate',2) (and even tried version 1)
to all the files where QtCore is imported but to no avail.
Also tried changing the version of the 'ui' to 1 in all the .ui files.
Thanks.
Comment 19•6 years ago
|
||
(In reply to rajalakshmi.v15 from comment #18)
> I started building from the 0.9.22 release since the latest one was giving
> me errors.
> ...
Hi Rajalkshmi, did you follow the instructions in https://github.com/mozilla/mozregression/blob/master/gui/README.rst ?
To be honest I'm not quite sure what's going on here. Definitely you should build/run from the github repo, not a downloaded archive. I think the cx-freeze step is only something we do when building for distribution. This bug is probably not the best place to debug these issues -- you can either email me (wlachance@mozilla.com) or we can chat on irc.mozilla.org #ateam (https://wiki.mozilla.org/IRC) during EST working hours.
Flags: needinfo?(wlachance)
Comment 20•6 years ago
|
||
(In reply to William Lachance (:wlach) (use needinfo!) from comment #13)
> No, you can set arguments with the configuration file (mozregression.cfg)
> now though, as described above. The relevant section is "cmdargs".
I can't get this to work. mozregression-gui 0.9.28. The following at the bottom of mozregression.cfg has no effect:
cmdargs = -new-window https://en.wikipedia.org
Flags: needinfo?(wlachance)
Updated•6 years ago
|
Assignee: rajalakshmi.v15 → nobody
Comment 21•6 years ago
|
||
Looks like rajalakshmi wasn't able to finish this, reopening the bug. I don't think this is a good first bug, too complex.
Whiteboard: [good first bug][lang=python] → [lang=python]
Comment 22•6 years ago
|
||
(In reply to Gingerbread Man from comment #20)
> (In reply to William Lachance (:wlach) (use needinfo!) from comment #13)
> > No, you can set arguments with the configuration file (mozregression.cfg)
> > now though, as described above. The relevant section is "cmdargs".
>
> I can't get this to work. mozregression-gui 0.9.28. The following at the
> bottom of mozregression.cfg has no effect:
> cmdargs = -new-window https://en.wikipedia.org
:( I suspect the PR (https://github.com/mozilla/mozregression/pull/483/) wasn't quite implemented correctly. Unfortunately I don't have time to look into this just at the moment.
Flags: needinfo?(wlachance)
Comment 23•6 years ago
|
||
Hi William! Can I work on this?
Assignee | ||
Comment 24•6 years ago
|
||
I've gone with just supporting a URL in the GUI, since that should be the most immediately useful enhancement that covers most people's needs. If someone needs more complicated arg support the CLI version is always there. (Though if anyone does want to go to the effort of implementing full arg-passing support in the GUI, it'd probably be accepted)
Assignee: nobody → moz-ian
Status: NEW → ASSIGNED
Assignee | ||
Updated•6 years ago
|
Summary: Mozregression GUI please add support for --arg → Mozregression GUI please add support for opening app with URL
Assignee | ||
Comment 25•6 years ago
|
||
Released in CLI 2.3.41 and GUI 0.9.39
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•