Closed Bug 1422698 Opened 7 years ago Closed 7 years ago

Make Windows code coverage build tier 2

Categories

(Testing :: Code Coverage, enhancement)

enhancement
Not set
normal

Tracking

(firefox59 fixed)

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: marco, Assigned: marco)

References

Details

Attachments

(1 file)

There are very few failures now, and they are all known intermittents.
Attached patch Patch (deleted) — Splinter Review
Assignee: nobody → mcastelluccio
Status: NEW → ASSIGNED
Attachment #8934106 - Flags: review?(jmaher)
Comment on attachment 8934106 [details] [diff] [review] Patch Review of attachment 8934106 [details] [diff] [review]: ----------------------------------------------------------------- the tests are still perma orange on mozilla-central- until they are much greener, I think we need to be tier-2.
Attachment #8934106 - Flags: review?(jmaher) → review-
Only mochitest-10, X7 and X8 are perma orange, but I'm marking them as failing today.
if you have a try push showing green (if there are retriggers and at least 50% are green that is ok too), I am happy to r+ this.
Depends on: 1423214
(In reply to Joel Maher ( :jmaher) (UTC-5) from comment #4) > if you have a try push showing green (if there are retriggers and at least > 50% are green that is ok too), I am happy to r+ this. As we discussed yesterday, after disabling the a11y test and making talos tier3 there was only a mochitest-1 test which was intermittently failing. I've triggered a try build with 5 retries and it was green 4 out of 5 times: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c85340053961eb410791cc979cfd58f524479cb1. It was also green in the latest 5 mozilla-central pushes. Do you think we can make the build and tests tier 2 now?
The only other thing broken is mochitest-webgl- we are wasting a lot of machine time and not even getting passes after the retries. Outside of that, all looks good.
Attachment #8934106 - Flags: review- → review?(jmaher)
Comment on attachment 8934106 [details] [diff] [review] Patch Review of attachment 8934106 [details] [diff] [review]: ----------------------------------------------------------------- excited to see this happen
Attachment #8934106 - Flags: review?(jmaher) → review+
Pushed by mcastelluccio@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f4608151c5e0 Make Windows coverage build and tests tier 2. r=jmaher
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: