Closed Bug 1423111 Opened 7 years ago Closed 6 years ago

mach clang-format only supports .cpp, .c and .h extensions

Categories

(Developer Infrastructure :: Lint and Formatting, defect)

Product:
Developer Infrastructure
Component:
Lint and Formatting
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: glandium, Unassigned)

References

(Blocks 1 open bug)

Details

At the very least, it should also support .cc, .m and .mm. Theoretically, it should also support .C and .hpp.
We didn't work on objective-c for now. For the rest, why would you want these extensions? $ find . -name '*.C'|wc -l 0 $ find . -name '*.hpp' ./js/rust/etc/wrapper.hpp ./media/webrtc/trunk/tools/gyp/test/compilable/src/lib1.hpp *.cc are just in thirdparty code.
Looking at it it should have support for ObjectiveC i will give it a try to see what happens.
Product: Core → Firefox Build System
Blocks: clang-format
Component: Source Code Analysis → Lint and Formatting
*.cc is actually commonly used in ipc/chromium at least which is Mozilla code (forked from upstream Chromium code). I will submit patch for that one at least.
Depends on: 1510919

With the latest changes landed in bug 1521460, let's call this fixed.

Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.