Closed Bug 1423543 Opened 7 years ago Closed 5 years ago

Fluent whitelist hook should exclude test files

Categories

(Core :: Internationalization, enhancement, P5)

Product:
Core
Component:
Internationalization
Type:
enhancement

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: Pike, Unassigned)

References

Details

In bug 1422487, we triggered the fluent whitelist hook on the example migration files. gandalf, stas, should we try to reduce the hook to just files that are part of our actual localizations? That would exclude test files, but also files where developers aren't yet ready to expose their files to localization. They could iterate faster, and we'd only require review once they're moving the file to l10n?
Flags: needinfo?(stas)
Flags: needinfo?(gandalf)
Would that mean testing if the file's path contains `/localization/`? Or that it doesn't contain `/test/`? Both?
Flags: needinfo?(gandalf) → needinfo?(l10n)
probably something like path.match(/browser|toolkit|...|/locales/en-US/) ... I'm totally screwing up regex syntax of various languages here.
Flags: needinfo?(l10n)

Flod and I talked about this hook recently, and we're entertaining the idea to migrate it to a review group in phabricator.

Anyway, moving Fluent bugs over to intl.

Component: Localization → Internationalization
Flags: needinfo?(stas)
Priority: -- → P5

Can we close this?

Yes, we removed the hook in bug 1575227.

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.