Closed
Bug 1424162
Opened 7 years ago
Closed 7 years ago
[a11y] Console clear, filter, etc. controls should be placed before output
Categories
(DevTools :: Console, defect, P3)
DevTools
Console
Tracking
(firefox59 fixed)
RESOLVED
FIXED
Firefox 59
Tracking | Status | |
---|---|---|
firefox59 | --- | fixed |
People
(Reporter: Jamie, Assigned: Jamie, Mentored)
References
(Blocks 1 open bug)
Details
(Keywords: access, good-first-bug)
Attachments
(1 file)
STR (with the NVDA screen reader):
1. Start NVDA and Firefox.
2. Press control+shift+k to open the Web Console.
3. Type foobar and press enter.
4. Shift+tab to the output area.
5. Press control+end to move to the bottom.
Expected: NVDA should report the last line of the output; e.g. "debugger eval code:1:1".
Actual: NVDA reports stuff from the console controls; e.g. "Persist logs".
As far as I can tell, the console controls (clear output, filter, etc.) are visually above the console output. However, for some reason, they're rendered later in the DOM. This is tedious for screen reader users because you can't just jump to the bottom of the input easily without having to cursor up through the toolbar. Either:
1. The controls should be moved above the output in the DOM; or
2. aria-owns should be used to reposition them for accessibility. For example, if the parent contained a node with id "console-output" and another with id "console-toolbar" in that order, the parent should have aria-owns="console-toolbar console-output" to reverse the order.
Updated•7 years ago
|
Blocks: devtoolsa11y
Comment 1•7 years ago
|
||
Marking this as good first bug since it should be only about swapping those 2 lines : https://searchfox.org/mozilla-central/rev/b0098afaeaad24a6752aa418ca3e86eade5fab17/devtools/client/webconsole/new-console-output/new-console-output-wrapper.js#202-203
Comment hidden (mozreview-request) |
Assignee | ||
Comment 3•7 years ago
|
||
I tested the patch and verified that the order is correct with the NVDA screen reader as outlined in comment 0. I verified to the best of my ability (using NVDA's mouse audio coordinates feature) that the positioning of the output and filter bar is unchanged visually. However, I'm totally blind, so I might have missed something.
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8937168 [details]
Bug 1424162: Put the filter bar before the console output in the web console.
https://reviewboard.mozilla.org/r/207882/#review213830
This is looking good visually, thanks Jamie.
Let's push this to TRY and land when everything is green.
Attachment #8937168 -
Flags: review?(nchevobbe) → review+
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fefc8c7584d8
Put the filter bar before the console output in the web console. r=nchevobbe
Comment 6•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Updated•6 years ago
|
Product: Firefox → DevTools
Updated•6 years ago
|
Assignee: nobody → jteh
You need to log in
before you can comment on or make changes to this bug.
Description
•