Closed
Bug 1424637
Opened 7 years ago
Closed 7 years ago
Convert from app units in nsDisplayCompositorHitTestInfo constructor instead of CreateWebRenderCommands()
Categories
(Core :: Graphics: WebRender, enhancement, P1)
Core
Graphics: WebRender
Tracking
()
RESOLVED
FIXED
mozilla59
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: jrmuizel, Assigned: kats)
References
(Blocks 1 open bug)
Details
(Whiteboard: [wr-mvp])
Attachments
(1 file)
mFrame->PresContext()->AppUnitsPerDevPixel() will access the frame and the style context which will cause cache misses during CreateWebRenderCommands() if we just do the conversion early, we'll likely avoid the misses and reduce cache pressure.
| Comment hidden (mozreview-request) |
|
||
Updated•7 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P1
Whiteboard: [wr-mvp]
|
Reporter | |
Comment 3•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8936278 [details] Bug 1424637 - Move the conversion from app units into the display item constructor. https://reviewboard.mozilla.org/r/207024/#review212872
Attachment #8936278 -
Flags: review?(jmuizelaar) → review+
Pushed by kgupta@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e2a0d93e77f7 Move the conversion from app units into the display item constructor. r=jrmuizel
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/e2a0d93e77f7
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
|
||
Updated•2 years ago
|
Blocks: wr-displaylist-perf
You need to log in
before you can comment on or make changes to this bug.
Description
•