Makoto Kato [:m_kato] Assignee
	Description • 7 years ago

inlineTableEditingEnabled and refreshInlineTableEditingUI are used by bluegriffon, but others aren't used by m-c, c-c and bluegriffon.  Let's remove this from nsIHTMLInlineTableEditor.idl

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900)
	Comment 2 • 7 years ago
mozreview-review

Comment on attachment 8944224 [details]
Bug 1425547 - Remove unused methods from nsIHTMLInlineTableEditor.

https://reviewboard.mozilla.org/r/214506/#review220446

::: editor/libeditor/HTMLEditorEventListener.cpp:214
(Diff revision 1)
> -  nsCOMPtr<nsIDOMElement> element = do_QueryInterface(target);
> +  nsCOMPtr<Element> element = do_QueryInterface(target);
>  
>    RefPtr<HTMLEditor> htmlEditor = mEditorBase->AsHTMLEditor();
>    MOZ_ASSERT(htmlEditor);
> -  htmlEditor->DoInlineTableEditingAction(element);
> +  htmlEditor->DoInlineTableEditingAction(*element);

This doesn't guarantee that element is always non-nullptr. So, you should call DoInlineTableEditingAction() only when element is no nullptr (its old behavior is, returning an error if element is nullptr and the result was ignored).

	Pulsebot
	Comment 3 • 7 years ago

Pushed by m_kato@ga2.so-net.ne.jp:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c208e865749a
Remove unused methods from nsIHTMLInlineTableEditor. r=masayuki

	Makoto Kato [:m_kato] Assignee
	Comment 4 • 7 years ago
mozreview-review

Comment on attachment 8944224 [details]
Bug 1425547 - Remove unused methods from nsIHTMLInlineTableEditor.

https://reviewboard.mozilla.org/r/214506/#review220764

	Masatoshi Kimura [:emk]
	Comment 5 • 7 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/c208e865749a#l3.58
> +HTMLEditor::DoInlineTableEditingAction(Element& aElement)

Why isn't the parameter type `const Element&`?

	Narcis Beleuzu [:NarcisB]
	Comment 6 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/c208e865749a