Closed
Bug 1425555
Opened 7 years ago
Closed 7 years ago
Avoid a fetch after showing the new bookmark dialog.
Categories
(Firefox :: Bookmarks & History, enhancement, P1)
Firefox
Bookmarks & History
Tracking
()
RESOLVED
FIXED
Firefox 61
| Tracking | Status | |
|---|---|---|
| firefox61 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
(Blocks 1 open bug)
Details
(Keywords: perf, Whiteboard: [fxsearch])
Attachments
(1 file)
In controller.js -> newItem we are currently doing a fetch just after the call to PlacesUIUtils.showBookmarkDialog.
Once we remove the sync places transactions (bug 1131491), I think we should look at changing PlacesUIUtils.showBookmarkDialog so that it returns the new/affected guids.
newItem can then simply select the new guid.
This might not be possible due to how async PlacesTransactions work, but it feels like we should be able to somehow get the new guid to return somehow.
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → standard8
Priority: P2 → P1
| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8960833 [details]
Bug 1425555 - Avoid a database fetch after showing the new bookmark dialog.
https://reviewboard.mozilla.org/r/229576/#review235402
it looks good and cheap :)
Attachment #8960833 -
Flags: review?(mak77) → review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ed517bd510e7
Avoid a database fetch after showing the new bookmark dialog. r=mak
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
You need to log in
before you can comment on or make changes to this bug.
Description
•