Closed
Bug 1425701
Opened 7 years ago
Closed 7 years ago
Assertion in AwaitAll causes tab crashes in debug builds
Categories
(Core :: WebRTC: Audio/Video, enhancement, P2)
Core
WebRTC: Audio/Video
Tracking
()
RESOLVED
INVALID
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | affected |
People
(Reporter: drno, Assigned: drno)
Details
Attachments
(1 file)
No description provided.
| Comment hidden (mozreview-request) |
|
Assignee | |
Updated•7 years ago
|
Rank: 10
Priority: P1 → P2
|
||
Comment 2•7 years ago
|
||
This code isn't in the tree. AwaitAll is added in bug 1404997 which hasn't been pushed yet.
|
|
||
Comment 3•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8937294 [details]
Bug 1425701: deleted unused TaskQueue RefPtr which hits assertions.
https://reviewboard.mozilla.org/r/207996/#review213838
Must have used aa working copy of bug
Attachment #8937294 -
Flags: review?(jyavenard) → review-
|
|
||
Updated•7 years ago
|
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INVALID
|
|
Assignee | |
Comment 4•7 years ago
|
||
Sorry about that. I spend the flight home trying to figure out why I kept seeing theses crashes. And after having identified the problem I did not realize that padenot had based his patch on all old revision of bug 1404997.
|
|
||
Comment 5•7 years ago
|
||
That caused a crash? A compilation warning sure... But that shouldn't crash. Ohhhhhh. Of course, shut-down wasn't called on it. I don't recall ever pushing that on reviewboard either. Maybe when I quickly fixed the crashes seen following Paul patches that caused a back out.
I have the bug ready to land I believe.
You need to log in
before you can comment on or make changes to this bug.
Description
•