Closed
Bug 1425868
Opened 7 years ago
Closed 7 years ago
Consolidate arrow panel styling
Categories
(Firefox :: Theme, defect)
Firefox
Theme
Tracking
()
RESOLVED
FIXED
Firefox 59
Tracking | Status | |
---|---|---|
firefox59 | --- | fixed |
People
(Reporter: ntim, Assigned: ntim)
References
Details
Attachments
(2 files)
Split out the following items from bug 1408121:
- Convert arrow panels to use CSS vars
-> Also got a green light from :shorlander at the y'all hands to remove the linear gradient on macOS
- Convert identity panel images to use context-fill
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → ntim.bugs
Comment hidden (mozreview-request) |
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8937490 [details]
Bug 1425868 - Consolidate arrow panel styling.
https://reviewboard.mozilla.org/r/208164/#review214110
::: toolkit/themes/windows/global/popup.css:109
(Diff revision 2)
> }
>
> %ifdef XP_WIN
> @media (-moz-windows-default-theme) {
> .panel-arrowcontent {
> --arrowpanel-border-color: hsla(210,4%,10%,.2);
This won't affect the arrow's border since the arrow isn't inside panel-arrowcontent. This should probably move to global.css.
Attachment #8937490 -
Flags: review?(dao+bmo)
Comment hidden (mozreview-request) |
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8937490 [details]
Bug 1425868 - Consolidate arrow panel styling.
https://reviewboard.mozilla.org/r/208164/#review214138
Looks good, thanks!
Attachment #8937490 -
Flags: review?(dao+bmo) → review+
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/4f6ed26bdb9b
Consolidate arrow panel styling. r=dao
Comment hidden (mozreview-request) |
Comment 8•7 years ago
|
||
Backed out changeset 4f6ed26bdb9b (bug 1425868) for build bustages on OS X and Windows r=backout on a CLOSED TREE
https://treeherder.mozilla.org/logviewer.html#?job_id=152352373&repo=autoland
https://hg.mozilla.org/integration/autoland/rev/76667880b457dfce628d8c00007ef37d93b86b2c
https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=4f6ed26bdb9bdb374e6555f3856090b931e209f2&filter-resultStatus=usercancel&filter-resultStatus=runnable&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception
Flags: needinfo?(ntim.bugs)
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Flags: needinfo?(ntim.bugs)
Comment 10•7 years ago
|
||
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/778dfad0f75e
Consolidate arrow panel styling. r=dao
Comment 11•7 years ago
|
||
Comment 12•7 years ago
|
||
Commit pushed to master at https://github.com/mozilla/activity-stream
https://github.com/mozilla/activity-stream/commit/1ef8164691910d9eb3ee0812c2881352c46e08f5
chore(styles): Port Bug 1425868 - Activity Stream changes to info panel (#3907)
Comment 13•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Comment 14•7 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•