Closed Bug 1425876 Opened 7 years ago Closed 7 years ago

Update Debugger Frontend (12-18)

Categories

(DevTools :: Debugger, defect, P3)

57 Branch
defect

Tracking

(firefox59 fixed)

RESOLVED FIXED
Firefox 59
Tracking Status
firefox59 --- fixed

People

(Reporter: jlast, Assigned: jlast)

References

Details

Attachments

(1 file)

No description provided.
Attached patch patch-12-18-6.patch (deleted) — Splinter Review
Attachment #8937695 - Flags: review?(jdescottes)
Assignee: nobody → jlaster
Severity: normal → enhancement
Status: NEW → ASSIGNED
Priority: -- → P3
ignore the latest try runs :)
Comment on attachment 8937695 [details] [diff] [review] patch-12-18-6.patch Review of attachment 8937695 [details] [diff] [review]: ----------------------------------------------------------------- LGTM. Spotted one issue, not a regression, according to :jlast already being fixed: When paused, editor always keeps scrolling back to the paused line. STRs: - add a breakpoint on a source file big enough to have scrollbar - hit breakpoint - scroll somewhere else, try to add a breakpoint => breakpoint is added but scrolls immediately to the paused line, very surprising for the user
Attachment #8937695 - Flags: review?(jdescottes) → review+
Can we get a commit list and some GH links, same as what you originally provided on Bug 1425912. Thanks
Flags: needinfo?(jlaster)
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Flags: needinfo?(jlaster)
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: