Ryan VanderMeulen [:RyanVM] Reporter
	Description • 7 years ago

[Tracking Requested - why for this release]: Permafailing tests when the Gecko version number is bumped to 60.

Looks like the probes these tests depend on are set to expire when Gecko hits 60:
WEBEXT_BACKGROUND_PAGE_LOAD_MS
WEBEXT_CONTENT_SCRIPT_INJECTION_MS
WEBEXT_EXTENSION_STARTUP_MS
WEBEXT_STORAGE_LOCAL_GET_MS
WEBEXT_STORAGE_LOCAL_SET_MS

Looks like there's some other expiring probes as well, but those are the ones causing test failures anyway. How do you want to proceed, Bob?

	Ryan VanderMeulen [:RyanVM] Reporter
	Comment 1 • 7 years ago

Also affected:
TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/mochitest/test_chrome_ext_contentscript_telemetry.html | No data recorded for histogram: WEBEXT_CONTENT_SCRIPT_INJECTION_MS
TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/test-oop-extensions/browser_ext_browserAction_telemetry.js | application terminated with exit code 11

Add two more to the list:
WEBEXT_BROWSERACTION_POPUP_OPEN_MS
WEBEXT_BROWSERACTION_POPUP_PRELOAD_RESULT_COUNT

	Bob Silverberg [:bsilverberg] Assignee
	Comment 3 • 7 years ago

Comment on attachment 8937762 [details]
Bug 1425957 - Extend webextension telemetry probes for another 3 releases,

Requesting data review for this patch which extends the expiry dates for a number of temporary telemetry probes whose data we are still consuming.

	Bob Silverberg [:bsilverberg] Assignee
	Comment 4 • 7 years ago

We plan to extend the probes, which should address the test issues.

	Andrew Swan [:aswan]
	Comment 5 • 7 years ago
mozreview-review

Comment on attachment 8937762 [details]
Bug 1425957 - Extend webextension telemetry probes for another 3 releases,

https://reviewboard.mozilla.org/r/208474/#review214562

This needs data review, not code review.

	Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)
	Comment 6 • 7 years ago

The early/first merge will be Jan. 11th. 
Tracking so we can make sure to check back in early January. 
Since don't have flags yet for 60, I'm just tracking this for 59.

	Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)
	Comment 7 • 7 years ago

Rebecca, can you cover data review? Or, if not, can you help find someone to cover that? Thanks.

	Ryan VanderMeulen [:RyanVM] Reporter
	Comment 8 • 7 years ago

Comment on attachment 8937762 [details]
Bug 1425957 - Extend webextension telemetry probes for another 3 releases,

Try confirms that this fixes all issues with these tests.

	Chenxia Liu [:liuche]
	Comment 9 • 7 years ago
mozreview-review

Comment on attachment 8937762 [details]
Bug 1425957 - Extend webextension telemetry probes for another 3 releases,

https://reviewboard.mozilla.org/r/208474/#review216884

Approving probe extensions.

	Pulsebot
	Comment 10 • 7 years ago

Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/c01ea7a84567
Extend webextension telemetry probes for another 3 releases, r=liuche

	Eliza Balazs [:ebalazs_]
	Comment 11 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/c01ea7a84567