Closed
Bug 1426098
Opened 7 years ago
Closed 7 years ago
Port bug 1425363 to SeaMonkey: Switch window menu to JS instead of RDF
Categories
(SeaMonkey :: General, enhancement)
Tracking
(seamonkey2.56 fixed, seamonkey2.53 fixed)
RESOLVED
FIXED
seamonkey2.56
People
(Reporter: frg, Assigned: stefanh)
References
(Blocks 1 open bug)
Details
(Whiteboard: SM2.53.1)
Attachments
(3 files, 1 obsolete file)
(deleted),
image/png
|
Details | |
(deleted),
image/png
|
Details | |
(deleted),
patch
|
frg
:
review+
frg
:
approval-comm-release+
|
Details | Diff | Splinter Review |
As far as I can tell we use it to show the Window list in the Window menu.
+++ This bug was initially created as a clone of Bug #1425363 +++
As far as we can tell, we have an RDF data source for the single purpose of doing this menu only on mac.
Instead we could just implement it with some simple JS.
Reporter | ||
Updated•7 years ago
|
Blocks: 2.56BulkMalfunctions
Assignee | ||
Comment 1•7 years ago
|
||
Reporter | ||
Comment 2•7 years ago
|
||
Old menu with numbers and hightlighted current window.
Reporter | ||
Comment 3•7 years ago
|
||
New menu
Reporter | ||
Comment 4•7 years ago
|
||
Comment on attachment 8941179 [details] [diff] [review]
Straight port
Window list works fine but the active window is no longer checked.
This does not seem to work:
> if (win == window) {
> - sep.setAttribute("checked", "true");
> - break;
> + item.setAttribute("checked", "true");
Not sure if this is because of a de-xbl bug? The old menu had type="radio" in it.
Do you want to try to fix it or should we file a followup bug?
The old menu did had the windows numbered and you could use the numbers as an accelerator key but personally I don't think we need to port this.
f+ for now.
Attachment #8941179 -
Flags: review?(frgrahl) → feedback+
Assignee | ||
Comment 5•7 years ago
|
||
Ah, the missing radio must be because I just create a plain menuitem (on Mac, this works fine).
Maybe we can file a follow-up for the number/accesskey? It's certainly doable.
Attachment #8941179 -
Attachment is obsolete: true
Attachment #8941542 -
Flags: review?(frgrahl)
Reporter | ||
Comment 6•7 years ago
|
||
Comment on attachment 8941542 [details] [diff] [review]
Now with type="radio"
That did the trick. Thanks++. Could you remove the period from "r=frg." when checking it in.
Attachment #8941542 -
Flags: review?(frgrahl) → review+
Pushed by stefanh@inbox.com:
https://hg.mozilla.org/comm-central/rev/4de3d93be690
Port bug 1425363 to SeaMonkey: Switch window menu to JS instead of RDF. r=frg.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•7 years ago
|
Target Milestone: --- → Seamonkey2.56
Assignee | ||
Comment 8•7 years ago
|
||
(In reply to Frank-Rainer Grahl (:frg) from comment #6)
> Could you remove the period from "r=frg." when
> checking it in.
Oops (I just did an hg import and a push).
Assignee | ||
Updated•7 years ago
|
Comment on attachment 8941542 [details] [diff] [review]
Now with type="radio"
This would be good for 2.53
Attachment #8941542 -
Flags: approval-comm-release?
Blocks: SM-killrdf
Reporter | ||
Comment 10•5 years ago
|
||
Comment on attachment 8941542 [details] [diff] [review]
Now with type="radio"
Added to the unofficial builds already
Attachment #8941542 -
Flags: approval-comm-release? → approval-comm-release+
Reporter | ||
Updated•5 years ago
|
status-seamonkey2.53:
--- → affected
Whiteboard: SM2.53.1
You need to log in
before you can comment on or make changes to this bug.
Description
•