Closed Bug 1426098 Opened 7 years ago Closed 7 years ago

Port bug 1425363 to SeaMonkey: Switch window menu to JS instead of RDF

Categories

(SeaMonkey :: General, enhancement)

All
Unspecified
enhancement
Not set
normal

Tracking

(seamonkey2.56 fixed, seamonkey2.53 fixed)

RESOLVED FIXED
seamonkey2.56
Tracking Status
seamonkey2.56 --- fixed
seamonkey2.53 --- fixed

People

(Reporter: frg, Assigned: stefanh)

References

(Blocks 1 open bug)

Details

(Whiteboard: SM2.53.1)

Attachments

(3 files, 1 obsolete file)

As far as I can tell we use it to show the Window list in the Window menu. +++ This bug was initially created as a clone of Bug #1425363 +++ As far as we can tell, we have an RDF data source for the single purpose of doing this menu only on mac. Instead we could just implement it with some simple JS.
Attached patch Straight port (obsolete) (deleted) — Splinter Review
Assignee: nobody → stefanh
Status: NEW → ASSIGNED
Attachment #8941179 - Flags: review?(frgrahl)
Attached image Capture-old.PNG (deleted) —
Old menu with numbers and hightlighted current window.
Attached image Capture-new.PNG (deleted) —
New menu
Comment on attachment 8941179 [details] [diff] [review] Straight port Window list works fine but the active window is no longer checked. This does not seem to work: > if (win == window) { > - sep.setAttribute("checked", "true"); > - break; > + item.setAttribute("checked", "true"); Not sure if this is because of a de-xbl bug? The old menu had type="radio" in it. Do you want to try to fix it or should we file a followup bug? The old menu did had the windows numbered and you could use the numbers as an accelerator key but personally I don't think we need to port this. f+ for now.
Attachment #8941179 - Flags: review?(frgrahl) → feedback+
Attached patch Now with type="radio" (deleted) — Splinter Review
Ah, the missing radio must be because I just create a plain menuitem (on Mac, this works fine). Maybe we can file a follow-up for the number/accesskey? It's certainly doable.
Attachment #8941179 - Attachment is obsolete: true
Attachment #8941542 - Flags: review?(frgrahl)
Comment on attachment 8941542 [details] [diff] [review] Now with type="radio" That did the trick. Thanks++. Could you remove the period from "r=frg." when checking it in.
Attachment #8941542 - Flags: review?(frgrahl) → review+
Pushed by stefanh@inbox.com: https://hg.mozilla.org/comm-central/rev/4de3d93be690 Port bug 1425363 to SeaMonkey: Switch window menu to JS instead of RDF. r=frg.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Seamonkey2.56
(In reply to Frank-Rainer Grahl (:frg) from comment #6) > Could you remove the period from "r=frg." when > checking it in. Oops (I just did an hg import and a push).
Comment on attachment 8941542 [details] [diff] [review] Now with type="radio" This would be good for 2.53
Attachment #8941542 - Flags: approval-comm-release?
Blocks: SM-killrdf
Comment on attachment 8941542 [details] [diff] [review] Now with type="radio" Added to the unofficial builds already
Attachment #8941542 - Flags: approval-comm-release? → approval-comm-release+
Whiteboard: SM2.53.1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: