Open
Bug 1426543
Opened 7 years ago
Updated 2 years ago
Consolidate some Treeherder platforms
Categories
(Firefox Build System :: Task Configuration, task)
Firefox Build System
Task Configuration
Tracking
(Not tracked)
NEW
People
(Reporter: gps, Unassigned)
References
Details
Attachments
(2 files)
We have a number of "platforms" on Treeherder that only have 1 or 2 tasks. This is wasteful of UI real estate.
We consolidated "rusttests" platforms in bug 1426292. Let's continue that process here.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 8•7 years ago
|
||
mozreview-review |
Comment on attachment 8938196 [details]
Bug 1426543 - Consolidate some MacOS Treeherder platforms;
https://reviewboard.mozilla.org/r/208936/#review214882
::: commit-message-62dd5:7
(Diff revision 3)
> +
> +We currently have separate Treeherder platforms for MacOS tasks. I
> +suspect these are a holdover from the days where we had "native" MacOS
> +builds and the new cross builds. We no longer have native MacOS
> +builds. And I don't see a valid reason to maintain separate "cross"
> +platforms for MacOS tasks for Treeherder display purposes.
My understanding is that this came from the time when we had multiple OS X test platforms (for different versions) and a single build platform (yet another version).
::: taskcluster/ci/build/macosx.yml:7
(Diff revision 3)
> description: "MacOS X x64 Cross-compile"
> index:
> product: firefox
> job-name: macosx64-debug
> treeherder:
> - platform: osx-cross/debug
> + platform: osx-10-10/debug
Are these "10-10" builds? Is the SDK in use in the cross-compiles is specific to 10.10? Would we want a new platform if we were to start cross-compiling in parallel on osx-10-13 or something?
Otherwise, perhaps better to just call these "osx/debug"?
Attachment #8938196 -
Flags: review?(dustin) → review+
Comment 9•7 years ago
|
||
mozreview-review |
Comment on attachment 8938197 [details]
Bug 1426543 - Consolidate "noopt" builds into existing platform;
https://reviewboard.mozilla.org/r/208938/#review214886
..modulo the same concerns with osx-10-10.
Attachment #8938197 -
Flags: review+
Comment 10•7 years ago
|
||
mozreview-review |
Comment on attachment 8938196 [details]
Bug 1426543 - Consolidate some MacOS Treeherder platforms;
https://reviewboard.mozilla.org/r/208936/#review215178
::: commit-message-62dd5:7
(Diff revision 3)
> +
> +We currently have separate Treeherder platforms for MacOS tasks. I
> +suspect these are a holdover from the days where we had "native" MacOS
> +builds and the new cross builds. We no longer have native MacOS
> +builds. And I don't see a valid reason to maintain separate "cross"
> +platforms for MacOS tasks for Treeherder display purposes.
Dustin is right. We had 10.7 tests and 10.10 tests, they were on separate platforms. And I think at some point, the builds were on 10.8 or 10.9, so they would even appear on a separate platform.
::: taskcluster/ci/build/macosx.yml:7
(Diff revision 3)
> description: "MacOS X x64 Cross-compile"
> index:
> product: firefox
> job-name: macosx64-debug
> treeherder:
> - platform: osx-cross/debug
> + platform: osx-10-10/debug
As a matter of fact, the current SDK we use is 10.11. But we still default to 10.7 for MACOSX_DEPLOYMENT_TARGET (we should probably change that). If anything, the platform should reflect MACOSX_DEPLOYMENT_TARGET.
10.10 is just what we happen to run tests on at the moment.
With all that being said, builds are already hard enough to find in the sea of jobs on treeherder, I'm not particularly convinced that putting builds and tests on the same lines is useful in any way at this point.
Attachment #8938196 -
Flags: review-
Comment 11•7 years ago
|
||
mozreview-review |
Comment on attachment 8938197 [details]
Bug 1426543 - Consolidate "noopt" builds into existing platform;
https://reviewboard.mozilla.org/r/208938/#review215184
Attachment #8938197 -
Flags: review+
Updated•7 years ago
|
Attachment #8938196 -
Flags: review?(core-build-config-reviews)
Updated•7 years ago
|
Attachment #8938197 -
Flags: review?(core-build-config-reviews)
Updated•7 years ago
|
Product: TaskCluster → Firefox Build System
Reporter | ||
Comment 13•6 years ago
|
||
Yes. I (or someone) needs to land the patch(es).
Flags: needinfo?(gps)
Updated•6 years ago
|
Assignee: gps → nobody
Status: ASSIGNED → NEW
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•