Closed Bug 1426906 Opened 7 years ago Closed 7 years ago

Intermittent leakcheck | default process: 1836 bytes leaked (Mutex, PollableEvent, ReentrantMonitor, nsAStreamCopier, nsPipe, ...)

Categories

(DevTools :: General, defect, P5)

defect

Tracking

(firefox-esr52 unaffected, firefox58 wontfix, firefox59 fixed, firefox60 fixed)

RESOLVED FIXED
Firefox 60
Tracking Status
firefox-esr52 --- unaffected
firefox58 --- wontfix
firefox59 --- fixed
firefox60 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: ochameau)

References

Details

(Keywords: intermittent-failure, memory-leak, Whiteboard: [stockwell unknown])

Attachments

(1 file)

This has been filed 21 days ago and according to the Neglected Oranges filter has reached 31 failures in the last week. It is failing on windows10-64-ccov / debug with a single exception on windows10-64 / debug on January 12th. Here is a recent relevant log file and a snippet from it: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-central&job_id=156060428&lineNumber=8523 23:39:50 INFO - TEST-INFO | leakcheck | default process: leaked 1 nsSocketTransportService 8521 23:39:50 INFO - TEST-INFO | leakcheck | default process: leaked 1 nsStringBuffer 8522 23:39:50 INFO - TEST-INFO | leakcheck | default process: leaked 1 nsTArray_base 8523 23:39:50 ERROR - 593 ERROR TEST-UNEXPECTED-FAIL | leakcheck | default process: 1836 bytes leaked (Mutex, PollableEvent, ReentrantMonitor, nsAStreamCopier, nsPipe, ...) 8524 23:39:50 INFO - == BloatView: ALL (cumulative) LEAK AND BLOAT STATISTICS, tab process 1960 8525 23:39:50 INFO - |<----------------Class--------------->|<-----Bytes------>|<----Objects---->| 8526 23:39:50 INFO - | | Per-Inst Leaked| Total Rem| 8527 23:39:50 INFO - 0 |TOTAL | 55 20| 45211 2| 8528 23:39:50 INFO - 721 |nsStringBuffer | 12 12| 14698 1| 8529 23:39:50 INFO - 761 |nsTArray_base | 8 8| 9843 1| 8530 23:39:50 INFO - nsTraceRefcnt::DumpStatistics: 831 entries 8531 23:39:50 INFO - TEST-INFO | leakcheck | tab process: leaked 1 nsStringBuffer 8532 23:39:50 INFO - TEST-INFO | leakcheck | tab process: leaked 1 nsTArray_base 8533 23:39:50 INFO - leakcheck | tab process: 20 bytes leaked (nsStringBuffer, nsTArray_base) 8534 23:39:50 INFO - runtests.py | Running tests: end. :pbro, could you please take a look at this?
Flags: needinfo?(pbrosset)
Whiteboard: [stockwell needswork]
Sorry about the delay. I'll forward this to Alex for further investigation and decision on what should be done here.
Flags: needinfo?(pbrosset) → needinfo?(poirot.alex)
win10 coverage runs with a few different build options- also the act of coverage causes some tests to run slower or fail if they are doing internal metrics counting.
This is most likely the same leak than bug 1294873, introduced by bug 1286281.
Flags: needinfo?(poirot.alex)
Here is an attempt to make test_websocket-server.html better wait for full completion: https://treeherder.mozilla.org/#/jobs?repo=try&revision=424d9b37da103f183c47c2e03e29abf6f90b0d13 But TBH, I have no idea what happens. The logs of this debug/ccov build do not print mochitest info() messages...
Looks like Michal suggestion from bug 1294873 comment 53 was right. The intermittent goes away by closing the stream: https://treeherder.mozilla.org/#/jobs?repo=try&revision=150da738b0cd4e41bec4e6d7c0461395e78f463d
Assignee: nobody → poirot.alex
Comment on attachment 8946849 [details] Bug 1426906 - Fix intermittent leak from test_websocket-server.html. This patch triggers another kind of intermittent.
Attachment #8946849 - Flags: review?(jryans)
Comment on attachment 8946849 [details] Bug 1426906 - Fix intermittent leak from test_websocket-server.html. https://reviewboard.mozilla.org/r/216736/#review222702 Thanks for looking at this! :) Seems reasonable to me.
Attachment #8946849 - Flags: review?(jryans) → review+
Pushed by apoirot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8721ef078294 Fix intermittent leak from test_websocket-server.html. r=jryans
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: