The MozReview "See it on Treeherder" URLs are using the 12 character SHA Treeherder revision URL format, for example: https://reviewboard.mozilla.org/r/200334/diff/4#index_header -> https://treeherder.mozilla.org/#/jobs?repo=try&revision=d2c15d19f890 ...rather than the 40 character form used elsewhere: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d2c15d19f8907297b6b39de5ec5717d3f8f7e920 This appears to come from: https://dxr.mozilla.org/hgcustom_version-control-tools/rev/ed9e3b65f21d64deafe063f88b17ccf51c9c2cf2/pylib/mozreview/mozreview/templates/mozreview/try_result.html#1 https://dxr.mozilla.org/hgcustom_version-control-tools/rev/ed9e3b65f21d64deafe063f88b17ccf51c9c2cf2/pylib/mozreview/mozreview/static/mozreview/js/autoland.js#335 https://dxr.mozilla.org/hgcustom_version-control-tools/rev/ed9e3b65f21d64deafe063f88b17ccf51c9c2cf2/pylib/mozreview/mozreview/fields.py#318 The 12 character URLs will soon stop working, since we're ready to proceed with bug 1306707.

mozreview is echoing the sha provided by autoland, which currently truncates to 12 chars.

Comment on attachment 8940594 [details] autoland: return full length commit SHAs (bug 1427311) https://reviewboard.mozilla.org/r/210804/#review216806 ::: autoland/hgext/rewritecommitdescriptions.py:44 (Diff revision 1) > def rewrite_commit_descriptions(ui, repo, base_node, descriptions=None): > > - def sha1_of(node): > + def sha1_short(node): > return repo[node].hex()[:12] > > + def sha1_full(node, full=False): `full` is unused here. Maybe it is used in a subsequent commit?

Comment on attachment 8940595 [details] autoland: fix autoland tests (bug 1427311) https://reviewboard.mozilla.org/r/210806/#review216808

Comment on attachment 8940596 [details] autoland: fix missing return value in PatchTransplant.apply_changes (bug 1427311) https://reviewboard.mozilla.org/r/210808/#review216810 ::: autoland/autoland/transplant.py:326 (Diff revision 1) > > # Apply the patch, with file rename detection (similarity). > # Using 95 as the similarity to match automv's default. > logger.info(self.run_hg(['import', '-s', '95', temp_file.name])) > > + return self.run_hg(['log', '-r', 'tip', '-T', '{node}']) I think this should use rev `.` instead of `tip`. I believe this because `.` is the active revision whereas `tip` is the most recently-committed revision. While they should be the same, `.` seems to be safer.

Pushed by bjones@mozilla.com: https://hg.mozilla.org/hgcustom/version-control-tools/rev/e80afa52502d autoland: return full length commit SHAs r=gps https://hg.mozilla.org/hgcustom/version-control-tools/rev/b5c384c32ffe autoland: fix autoland tests r=gps https://hg.mozilla.org/hgcustom/version-control-tools/rev/c65b7133ec9d autoland: fix missing return value in PatchTransplant.apply_changes r=gps

Many thanks Byron :-)

The changes here don't appear to be in production - do you know when the next deploy will be taking place?

hrm, it's already deployed. i must have missed something - sorry about that; reopening.

will fix in bug 1434919