Closed Bug 1427358 Opened 7 years ago Closed 7 years ago

The drop preview is very slow if a Top Site from a row is quickly dragged over the ones from the other row(s)

Categories

(Firefox :: New Tab Page, defect, P2)

defect

Tracking

()

RESOLVED WORKSFORME
Iteration:
59.4 - Jan 15
Tracking Status
firefox-esr52 --- unaffected
firefox57 --- unaffected
firefox58 --- unaffected
firefox59 --- fixed

People

(Reporter: cmuresan, Assigned: rrosario)

References

Details

Attachments

(2 files)

[Affected versions]: - Firefox 59.0a1 Build ID 20171228220110 [Affected Platforms]: - All Windows - All Mac [Prerequisites]: - Have enough history so that all 12 Top Sites are populated. [Steps to reproduce]: 1. Start the browser with the profile from prerequisites. 2. Quickly drag a Top Site from the 1st row over the ones from the 2nd row. 3. Observe the behavior. [Expected results]: - The preview appears as soon as the cursor is over the Top Sites. [Actual results]: - The preview lags behind a few Top Sites. [Notes]: - The issue is not reproducible if the Top Site is dragged over the same row it came from. - The issue is also reproducible if a Top Site is dragged from the 2nd row over the 1st. - Attached a screen recording of the issue.
Ha. I wonder if this is just javascript processing all the recursion when dragging from further away. You can somewhat see the delay in the video when dragging the last item to the first spot of the second row. We can easily get tens if not hundreds of dragover events. One simple short circuit would probably be to not recompute if the dragover position is the same as the last computed dragover.
Depends on: 1402192
Assignee: nobody → rrosario
Iteration: --- → 1.27
Priority: -- → P2
Iteration: 1.27 → 60.1 - Jan 29
Attached video dragdropperf.mp4 (deleted) —
Added my recording of drag drop in today's Nightly on reference hardware. The performance seems to have improved. Can you still reproduce? Thanks.
Flags: needinfo?(ciprian.muresan)
Seems like bug 1428488 also fixed the slowness. Closing as worksforme.
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: needinfo?(ciprian.muresan)
Resolution: --- → WORKSFORME
I'll guess it was bug 1428727 as it replaced the recursion with some loops.
Iteration: 60.1 - Jan 29 → 59.4 - Jan 15
Depends on: 1428727
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: