Closed Bug 1427363 Opened 7 years ago Closed 7 years ago

Remove "autocomplete-result-popup" and related bindings

Categories

(Toolkit :: Autocomplete, task, P2)

task

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: Paolo, Assigned: Paolo)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

The tree-based "autocomplete-result-popup" binding can be removed together with related bindings after the last use in the search bar has been removed.
Blocks: 1427364
Depends on: 1427366
Looks like there is some more work to do in bug 1427366.
We should file a bug for comm-central where autocomplete-result-popup is still used, at least in:
https://dxr.mozilla.org/comm-central/source/suite/common/communicator.css#20
And in general, to make them aware of the change.
Priority: -- → P2
Blocks: 1429115
Attachment #8939096 - Flags: review?(mak77)
Attachment #8939097 - Flags: review?(mak77)
Comment on attachment 8939096 [details]
Bug 1427363 - Part 1 - Remove "autocomplete-result-popup" and related bindings.

https://reviewboard.mozilla.org/r/209518/#review221680
Attachment #8939096 - Flags: review?(mak77) → review+
Comment on attachment 8939097 [details]
Bug 1427363 - Part 2 - Flatten inheritance for "autocomplete-rich-result-popup".

https://reviewboard.mozilla.org/r/209516/#review221690
Attachment #8939097 - Flags: review?(mak77) → review+
Pushed by paolo.mozmail@amadzone.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/184034807d27
Part 1 - Remove "autocomplete-result-popup" and related bindings. r=mak
https://hg.mozilla.org/integration/mozilla-inbound/rev/86fa284eb0e0
Part 2 - Flatten inheritance for "autocomplete-rich-result-popup". r=mak
https://hg.mozilla.org/mozilla-central/rev/184034807d27
https://hg.mozilla.org/mozilla-central/rev/86fa284eb0e0
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Thanks Marco, I've seen in, but this is in SM, suite/.
Flags: needinfo?(frgrahl)
Jorg, thanks. Paolo already gave us a heads up in bug 1429115. With luck we don't need to do anything/much. Will test it now that the patches have been pushed.
Flags: needinfo?(frgrahl)
Type: enhancement → task
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: