Closed
Bug 1427449
Opened 7 years ago
Closed 7 years ago
doorhanger accesskeys for some letters (Alt + ...) close doorhanger, but don't trigger intended action
Categories
(Core :: DOM: UI Events & Focus Handling, defect, P2)
Core
DOM: UI Events & Focus Handling
Tracking
()
VERIFIED
FIXED
mozilla59
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox57 | --- | unaffected |
firefox58 | + | wontfix |
firefox59 | --- | verified |
firefox60 | --- | verified |
People
(Reporter: aryx, Assigned: enndeakin)
References
Details
(Keywords: regression)
Attachments
(1 file)
(deleted),
patch
|
Felipe
:
review+
|
Details | Diff | Splinter Review |
This is a regression from bug 380637.
The doorhanger accesskeys for some letters close the doorhanger, but don't trigger intended action.
Steps to reproduce (Windows 8.1, all builds after bug 380638 landed):
1. Open https://permission.site/
2. Click on "Notifications".
3. Press Alt + N for "Not Now".
Actual result:
Doorhanger closes, and gets immediately opened again.
Expected result:
Doorhanger closed, "Notification" button gets red background.
This also can fail silently. E.g. the prompt to update address or credit card data or save it as new data fails silently.
Further observations show that e.g. "h" works as accesskey but "n" doesn't.
[Tracking Requested - why for this release]:
Regression, breaks accessibility and actions can fail silently.
Reporter | ||
Updated•7 years ago
|
Flags: needinfo?(enndeakin)
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → enndeakin
Status: NEW → ASSIGNED
Flags: needinfo?(enndeakin)
Assignee | ||
Comment 2•7 years ago
|
||
Attachment #8941153 -
Flags: review?(felipc)
Updated•7 years ago
|
Priority: -- → P2
Updated•7 years ago
|
Attachment #8941153 -
Flags: review?(felipc) → review+
Pushed by neil@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/76990027c9f8
don't close the menu in nsMenuBarFrame::FindMenuWithShortcut when just checking if such a menu shortcut key exists from the keydown event handler, also for extra safety this should only happen for menus not panels, r=felipe
Comment 4•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Reporter | ||
Updated•7 years ago
|
Status: RESOLVED → VERIFIED
Comment 5•7 years ago
|
||
This doesn't seem like the kind of patch we'd want to risk taking in a dot release, so calling this wontfix for 58. Feel free to set it back to affected and nominate for mozilla-release approval if you feel strongly otherwise, however.
Updated•7 years ago
|
Flags: qe-verify+
Comment 6•7 years ago
|
||
I have managed to reproduce the issue mentioned in comment 0 using Firefox 59.0a1 (BuildId:20171230220352).
This issue is verified fixed on Firefox 60.0a1 (BuildId:20180206220102) and 59.0b7 (BuildID:20180205211730) using Windows 10 64bit.
Updated•6 years ago
|
Component: Event Handling → User events and focus handling
You need to log in
before you can comment on or make changes to this bug.
Description
•