Closed
Bug 1428002
Opened 7 years ago
Closed 7 years ago
Enable <script type="module"> in nightly builds
Categories
(Core :: DOM: Core & HTML, enhancement, P3)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla59
Tracking | Status | |
---|---|---|
firefox59 | --- | fixed |
People
(Reporter: jonco, Assigned: jonco)
References
Details
(Keywords: dev-doc-needed)
Attachments
(2 files)
(deleted),
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
When the web platform tests failures related to module scripts are fixed, I'd like to enable this feature by default in nightly builds. It's preffed off.
Assignee | ||
Comment 2•7 years ago
|
||
Patch to enable modules in nightly. What do you think? Do I need to send a dev.platform email for this?
Attachment #8940798 -
Flags: review?(bugs)
Comment 3•7 years ago
|
||
Yes, please send email to dev.platform.
I guess we don't need to support module workers yet.
Chrome bug for that is https://bugs.chromium.org/p/chromium/issues/detail?id=680046
Comment 4•7 years ago
|
||
Comment on attachment 8940798 [details] [diff] [review]
bug1428002-enable-in-nightly
oh, this is nightly only... well, even then it would be good to notify dev.platform, but this isn't really intent-to-ship yet.
Attachment #8940798 -
Flags: review?(bugs) → review+
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/28f972e51e33
Enable <script type="module"> in nightly builds r=smaug
Comment 6•7 years ago
|
||
Backed out changeset 28f972e51e33 (bug 1428002) for wpt1 failures in /html/dom/interfaces.html
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=7ddce698d4b2eb799287f03731a2302c1cd7712c&filter-classifiedState=unclassified&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-classifiedState=unclassified&fromchange=0894fbaddc88e7f6b9cd6bb5f9cad6cf81254ecc&selectedJob=155005877
https://hg.mozilla.org/integration/mozilla-inbound/rev/7ddce698d4b2eb799287f03731a2302c1cd7712c
Flags: needinfo?(jcoppeard)
Assignee | ||
Comment 7•7 years ago
|
||
Patch to update test code that expects module scripts to not be enabled.
To deal with modules being enabled on nightly but disabled elsewhere, the WPT tests set the pref explicitly.
Flags: needinfo?(jcoppeard)
Attachment #8941082 -
Flags: review?(bugs)
Comment 8•7 years ago
|
||
Comment on attachment 8941082 [details] [diff] [review]
bug1428002-fix-tests
removing test_moduleScriptsNotRun.html is a bit annoying, but I guess it is ok atm.
Attachment #8941082 -
Flags: review?(bugs) → review+
Assignee | ||
Comment 9•7 years ago
|
||
(In reply to Olli Pettay [:smaug] from comment #8)
> removing test_moduleScriptsNotRun.html is a bit annoying, but I guess it is
> ok atm.
I think I can make it just skip this test on nightly. I'll do that.
Comment 10•7 years ago
|
||
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8e14dd890c5e
Enable <script type="module"> in nightly builds r=smaug
Comment 11•7 years ago
|
||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Updated•7 years ago
|
Keywords: dev-doc-needed
You need to log in
before you can comment on or make changes to this bug.
Description
•