Closed
Bug 1428176
Opened 7 years ago
Closed 7 years ago
Enable browser_startup.js on DevEdition builds
Categories
(Firefox :: General, enhancement)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 59
Tracking | Status | |
---|---|---|
firefox59 | --- | fixed |
People
(Reporter: florian, Assigned: florian)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
RyanVM
:
review+
RyanVM
:
feedback+
|
Details | Diff | Splinter Review |
Per bug 1410072 comment 8 and 9, we need to enable recording stacks in mozJSComponentLoader.cpp for dev edition builds if we want to enable browser_startup.js there.
Assignee | ||
Comment 1•7 years ago
|
||
Changing the ifdef means this will be compiled in, but it'll cause little overhead unless the pref is enabled, only a Preferences::GetBool("browser.startup.record", false) call.
Attachment #8939966 -
Flags: review?(continuation)
Assignee | ||
Comment 2•7 years ago
|
||
Ryan, could you please verify that this works as expected on a 'real' devedition build?
Flags: needinfo?(ryanvm)
Updated•7 years ago
|
Attachment #8939966 -
Flags: review?(continuation) → review+
Comment 3•7 years ago
|
||
Made a couple changes per IRC discussion with Andrew and Florian, but this version is confirmed working (with logs confirming the test operating as expected) :)
Attachment #8939966 -
Attachment is obsolete: true
Flags: needinfo?(ryanvm)
Attachment #8940044 -
Flags: review+
Attachment #8940044 -
Flags: feedback+
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a6c8d268c35e
Enable browser_startup.js on DevEdition builds. r=mccr8, r=florian
Comment 5•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
You need to log in
before you can comment on or make changes to this bug.
Description
•