Closed
Bug 1428229
Opened 7 years ago
Closed 7 years ago
Remove FakeString and NotNull member initializations
Categories
(Core :: DOM: Core & HTML, enhancement)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla59
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: qdot, Assigned: qdot)
References
Details
Attachments
(2 files)
In bug 1406820, initializations were added for members of classes that left them out for optimization reasons. These should be removed.
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 3•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8940344 [details]
Bug 1428229 - Partial backout a4094a8fa08d (bug 1406820) due to optimization removals;
https://reviewboard.mozilla.org/r/210616/#review216342
::: dom/bindings/BindingDeclarations.h:348
(Diff revision 1)
>
> template<>
> class Optional<nsAString>
> {
> public:
> - Optional()
> + Optional() : mPassed(false) {}
Actually, these changes are probably ok. mPassed really is redundant with mStr...
Attachment #8940344 -
Flags: review?(bzbarsky) → review+
|
|
||
Comment 4•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8940345 [details]
Bug 1428229 - Add comments about purposefully uninitialized variables in BindingDeclarations;
https://reviewboard.mozilla.org/r/210618/#review216344
Thank you!
Attachment #8940345 -
Flags: review?(bzbarsky) → review+
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
Pushed by kmachulis@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/58d3a80ef7f7
Partial backout a4094a8fa08d (bug 1406820) due to optimization removals; r=bz
https://hg.mozilla.org/integration/autoland/rev/98a6f537336d
Add comments about purposefully uninitialized variables in BindingDeclarations; r=bz
|
||
Comment 8•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•