Closed
Bug 1428305
Opened 7 years ago
Closed 7 years ago
Clobbering node_modules on ESLint upgrade removed too much on Windows due to bad handling of symlinks
Categories
(Developer Infrastructure :: Lint and Formatting, enhancement, P1)
Tracking
(firefox59 fixed)
RESOLVED
FIXED
mozilla59
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
When we landed the ESLint 3 -> 4 upgrade (bug 1371293), I had a couple of reports of it removing too much on Windows, and I didn't really get around to investigating it until now.
It turns out that using python's shutil.rmtree implementation is removing the contents of symlinked directories on Windows.
Thankfully, clobber.py provides a hint - using `winrm.exe` on Windows does the right thing. I'm working up a patch for this.
Interestingly, mozfiles's remove function which is used as a fallback for Windows (and by default on non-Windows) still does the wrong thing on Windows (I filed bug 1428304).
|
Assignee | |
Comment 1•7 years ago
|
||
Developer/testing note. Mercurial revision prior to ESLint 4 upgrade: d61d99ecc3c8, revision after upgrade: a60e6fbce675
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Updated•7 years ago
|
Priority: -- → P1
|
||
Comment 3•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8940178 [details]
Bug 1428305 - When clobbering node_modules for ESLint on Windows, use winrm to better handle symlinks.
https://reviewboard.mozilla.org/r/210492/#review216154
Lgtm
Attachment #8940178 -
Flags: review?(ahalberstadt) → review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b9755c321f88
When clobbering node_modules for ESLint on Windows, use winrm to better handle symlinks. r=ahal
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
|
||
Updated•7 years ago
|
Product: Testing → Firefox Build System
|
||
Updated•6 years ago
|
Version: Version 3 → 3 Branch
|
|
||
Updated•2 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•