Closed
Bug 1428436
Opened 7 years ago
Closed 7 years ago
Several accessibility and extensibility improvements to TreeView components.
Categories
(DevTools :: Shared Components, enhancement)
Tracking
(firefox60 fixed)
RESOLVED
FIXED
Firefox 60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: yzen, Assigned: yzen)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
Honza
:
review+
|
Details | Diff | Splinter Review |
Several things that would further improve a11y and extensibility:
* Allow for defining a selected prop for a default selected row.
* Allow for customizing onClickRow functionality.
* Improve row selection fallback for when currently selected row is rendered out.
* Select first row on Home key
* Select last row on End key
* Ensure that keyboard focus always remain on the tree container itself.
* Ensure that keyboard focus highlight for the tree is only shown when the tree is focused with the keyboard (not mouse).
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #8947609 -
Flags: review?(odvarko)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8947609 [details] [diff] [review]
1428436 patch
Review of attachment 8947609 [details] [diff] [review]:
-----------------------------------------------------------------
Looks reasonable, thanks!
R+ assuming try is green
Honza
Attachment #8947609 -
Flags: review?(odvarko) → review+
Pushed by yura.zenevich@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f81606cd2958
further improving TreeView accessibility. r=Honza
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•