When enabling Web Authentication, we blew up credentialscontainer-create-basics.https.html : TEST-UNEXPECTED-PASS | /credential-management/credentialscontainer-create-basics.https.html | navigator.credentials.create() with bogus password data - expected FAIL Log: https://treeherder.mozilla.org/logviewer.html#?job_id=155091670&repo=autoland&lineNumber=1765 We need to resolve these tests somehow. This is blocking Bug 1428918.

Comment on attachment 8941178 [details] Bug 1429171 - Enable portions of the Credential Management WPTs https://reviewboard.mozilla.org/r/211442/#review217240 This seems reasonable to me, but I imagine we should get someone who's actually familiar with the web platform tests to review this. ::: testing/web-platform/meta/credential-management/credentialscontainer-create-basics.https.html.ini (Diff revision 1) > > [navigator.credentials.create() with valid HTMLFormElement] > expected: FAIL > > - [navigator.credentials.create() with bogus password data] > - expected: FAIL Do we want to remove these or are we supposed to change the 'FAIL' to a 'PASS' or something?

Comment on attachment 8941178 [details] Bug 1429171 - Enable portions of the Credential Management WPTs https://reviewboard.mozilla.org/r/211442/#review217240 Fair, thanks! > Do we want to remove these or are we supposed to change the 'FAIL' to a 'PASS' or something? We only need to change set an `expected` value if it's not supposed to be PASS, so judging by other tests, removal is the right thing to do here.

Comment on attachment 8941178 [details] Bug 1429171 - Enable portions of the Credential Management WPTs https://reviewboard.mozilla.org/r/211442/#review217286

Thanks, James! Try-run looks good now that whatever hiccup earlier went away: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8ab6f1d38675077904f923603e8e6ac39f71dd93 So let's land this, and we can try Bug 1428918 again after.

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. hg error in cmd: hg rebase -s 9de2146aba10 -d 6538de3b6137: rebasing 441606:9de2146aba10 "Bug 1429171 - Enable portions of the Credential Management WPTs r=jgraham" (tip) merging testing/web-platform/meta/credential-management/credentialscontainer-create-basics.https.html.ini merging testing/web-platform/meta/credential-management/idl.https.html.ini warning: conflicts while merging testing/web-platform/meta/credential-management/credentialscontainer-create-basics.https.html.ini! (edit, then use 'hg resolve --mark') warning: conflicts while merging testing/web-platform/meta/credential-management/idl.https.html.ini! (edit, then use 'hg resolve --mark') unresolved conflicts (see hg resolve, then hg rebase --continue)

Pushed by ttaubert@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/03920709eed2 Enable portions of the Credential Management WPTs r=jgraham