Closed
Bug 1429244
Opened 7 years ago
Closed 7 years ago
Make Selection to use main thread only AddRef/Release
Categories
(Core :: DOM: Selection, enhancement)
Core
DOM: Selection
Tracking
()
RESOLVED
FIXED
mozilla59
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: smaug, Assigned: smaug)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
patch
|
mccr8
:
review+
|
Details | Diff | Splinter Review |
NS_IMPL_MAIN_THREAD_ONLY_CYCLE_COLLECTING_ADDREF/RELEASE is a bit faster than the normal CC_ADDREF/RELEASE.
Patch coming.
|
Assignee | |
Comment 1•7 years ago
|
||
We didn't have the basic NS_IMPL_MAIN_THREAD_ONLY_CYCLE_COLLECTING_RELEASE,
only the one with _LAST_RELEASE.
Since we don't have use for _DESTROY variant yet, I went with this simple approach.
The new macro uses the coding style of the surrounding code, so
nsISupports *base and not nsISupports* base
Attachment #8941249 -
Flags: review?(continuation)
|
|
Assignee | |
Comment 2•7 years ago
|
||
remote: View your change here:
remote: https://hg.mozilla.org/try/rev/23176186c7183a69b6851b027380f411ff968fad
remote:
remote: Follow the progress of your build on Treeherder:
remote: https://treeherder.mozilla.org/#/jobs?repo=try&revision=23176186c7183a69b6851b027380f411ff968fad
remote: recorded changegroup in replication log in 0.071s
|
||
Updated•7 years ago
|
Attachment #8941249 -
Flags: review?(continuation) → review+
Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6c6f3fd9c5e1
Make Selection to use main thread only AddRef/Release, r=mccr8
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•