Closed
Bug 1429352
Opened 7 years ago
Closed 7 years ago
progressmeter.css cleanup
Categories
(Toolkit :: Themes, enhancement, P3)
Toolkit
Themes
Tracking
()
RESOLVED
FIXED
mozilla59
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: dao, Assigned: dao)
References
Details
Attachments
(1 file)
- remove obsolete .progressmeter-statusbar rule
- replace Windows 98 style shadow with a flat one (this is only used on platforms where we don't implement -moz-appearance: progressbar -- not sure that this actually the case anywhere)
- minor formatting fixes
| Comment hidden (mozreview-request) |
|
Assignee | |
Updated•7 years ago
|
status-firefox59:
affected → ---
Priority: -- → P3
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8941379 [details]
Bug 1429352 - progressmeter.css cleanup.
https://reviewboard.mozilla.org/r/211694/#review217464
LGTM!
::: toolkit/themes/windows/global/progressmeter.css
(Diff revision 1)
> - border: 2px solid;
> + border: 1px solid ThreeDShadow;
> - -moz-border-top-colors: ThreeDShadow -moz-Dialog;
> - -moz-border-right-colors: ThreeDHighlight -moz-Dialog;
> - -moz-border-bottom-colors: ThreeDHighlight -moz-Dialog;
> - -moz-border-left-colors: ThreeDShadow -moz-Dialog;
> - background-color: -moz-Dialog;
As mentioned on IRC, it might be better to keep that background-color. Up to you :)
Attachment #8941379 -
Flags: review?(ntim.bugs) → review+
| Comment hidden (mozreview-request) |
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c0f34f8aaef3
progressmeter.css cleanup. r=ntim
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•