Closed
Bug 1429464
Opened 7 years ago
Closed 7 years ago
Remove toolbox binding
Categories
(Toolkit :: XUL Widgets, task)
Toolkit
XUL Widgets
Tracking
()
RESOLVED
FIXED
mozilla60
Tracking | Status | |
---|---|---|
firefox60 | --- | fixed |
People
(Reporter: ntim, Assigned: timdream)
References
Details
Attachments
(1 file)
As of bug 1428938, the toolbox binding is only used for the `palette` field and has `-moz-appearance: toolbox;` associated to it.
The `palette` field can probably be folded with the CustomizableUI.jsm module, while the styles can be applied where applicable.
Comment 1•7 years ago
|
||
I'm assuming this also requires loading toolbars.css as a UA sheet so that we don't lose those styles from toolbar-base
Depends on: 1420229
Reporter | ||
Comment 2•7 years ago
|
||
(In reply to Brian Grinstead [:bgrins] from comment #1)
> I'm assuming this also requires loading toolbars.css as a UA sheet so that
> we don't lose those styles from toolbar-base
There's really not much from toolbars.css that toolbox needs. It just needs -moz-appearance: toolbox; which may not require everything bug 1420229 is doing.
Comment 3•7 years ago
|
||
(In reply to Tim Nguyen :ntim from comment #2)
> (In reply to Brian Grinstead [:bgrins] from comment #1)
> > I'm assuming this also requires loading toolbars.css as a UA sheet so that
> > we don't lose those styles from toolbar-base
>
> There's really not much from toolbars.css that toolbox needs. It just needs
> -moz-appearance: toolbox; which may not require everything bug 1420229 is
> doing.
Indeed - it looks like we could move the `-moz-appearance: toolbox` rule into xul.css since that's the only relevant thing set in toolbars.css (https://searchfox.org/mozilla-central/search?q=toolbox+%7B&path=).
Assignee | ||
Updated•7 years ago
|
Flags: needinfo?(timdream)
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → timdream
Status: NEW → ASSIGNED
Flags: needinfo?(timdream)
Comment hidden (mozreview-request) |
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8948320 [details]
Bug 1429464 - Remove toolbox binding
https://reviewboard.mozilla.org/r/217802/#review223672
Thanks!
Note that the try push is broken because of the cert stuff that's closing trees at the moment, but it loooooks like we might be OK here.
::: commit-message-ef1fe:4
(Diff revision 1)
> +- Remove the markup that initialize the palette field to null,
> + effectively initialize the value to undefined, which is still
> + falsey.
Can you add here that the toolbar binding remains responsible for initializing the toolbox's palette property with an actual DOM node? Thanks!
Attachment #8948320 -
Flags: review?(gijskruitbosch+bugs) → review+
Comment hidden (mozreview-request) |
Pushed by timdream@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/df6d2c3ee671
Remove toolbox binding r=Gijs
Comment 8•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Reporter | ||
Updated•5 years ago
|
Type: enhancement → task
You need to log in
before you can comment on or make changes to this bug.
Description
•