Lucas Reporter
	Description • 7 years ago

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20180103231032

Steps to reproduce:

Visiting Sites like 
https://alligator.io/js/intro-progressive-web-apps/
or 
https://www.sitepoint.com/getting-started-with-service-workers/
or
https://serviceworke.rs/push-replace_demo.html

cannot register a ServiceWorker successfully, as an error occurs on the console in the first two cases, and the demo does not work in the last one.
---------------------------------------------------------------
This also happens, if (for debugging purposes) a ServiceWorker tries to install on localhost.
The steps to reproduce are as following:

1) Writing a simple html page, with a service worker installer, and a minimal serviceWorker.
The installer should catch the error.

2) provide the page at localhost (or 127.0.0.1, the bug will occur in both cases)

3) The error will occur, that the  "The operation is insecure." as the following DomException and the serviceWorker will not install.

---------------------------------------------------------
However, a ServiceWorker will install correctly Sites like youtube.com.

This Bug occured on Firefox on Windows and Mac. It was not tested on Linux. No Extensions were installed on Firefox at this moment. 


Actual results:

The registration of ServiceWorkers fails in many cases with the error "The operation is insecure.", even if the same Service Worker registers successfully in Chrome and Edge. This also happens on localhost, and many pages on the Web which are provided via https, as described in the "steps to reproduce" section.

---------------------------------------------------------------
This might also be an issue with LetsEncrypt, as statet here:
https://github.com/mozilla/serviceworker-cookbook/issues/284

However, apparently no bug was filed. 


Expected results:

In all described cases the service Workers should install successfully.

	Ben Kelly [:bkelly, not reviewing]
	Comment 1 • 7 years ago

What are your cookie and storage preferences set to?  Open:

  Menu->Options->Privacy&Security

And look at History section.  Does it say "Nightly will: remember history"?

	Ben Kelly [:bkelly, not reviewing]
	Comment 2 • 7 years ago

If you try in nightly firefox, do you get a message like this?

  "Failed to register/update a ServiceWorker for scope ‘https://alligator.io/’: Storage access is restricted in this context due to user settings or private browsing mode."

This message was added in FF59.

	Ben Kelly [:bkelly, not reviewing]
	Comment 3 • 7 years ago

Note, if you have cookies set to "Keep until I close firefox", we also block service workers.  This is because we don't have support for actually wiping non-cookie storage like Cache API, IDB, etc at the end of the browsing session yet.  See bug 1400678.

	lists
	Comment 4 • 7 years ago

Just got burned by this too, Yes my cookies are "Keep until I close Firefox" just goes to prove you guys need to fix/update that setting language LAST YEAR.  Drop the word cookies as the main language in the setting/UI and make it one in a list of things that gets wiped on Firefox close, 

"Persistent storage: Keep until I close Firefox (Block service worker registration)" 

The language of Keep until means that the service worker would still register, but that you'd de-register on Firefox close, but instead you just throw a DOM Insecure error on registration.  What a mess.

	Ben Kelly [:bkelly, not reviewing]
	Comment 5 • 7 years ago

(In reply to lists from comment #4)
> The language of Keep until means that the service worker would still
> register, but that you'd de-register on Firefox close, but instead you just

That is bug 1400678 as I mentioned in the last comment.  Its being prioritized.

> throw a DOM Insecure error on registration.  What a mess.

Just to clarify, we don't throw an error.  We reject the promise.  Generally sites need to handle rejected registration promises for a number of reasons.  For example, if the script 404s, etc.

	Lucas Reporter
	Comment 6 • 7 years ago

(In reply to Ben Kelly [:bkelly] from comment #3)
> Note, if you have cookies set to "Keep until I close firefox", we also block
> service workers.  This is because we don't have support for actually wiping
> non-cookie storage like Cache API, IDB, etc at the end of the browsing
> session yet.  See bug 1400678.

Yes, thanks, this resolved the issue. :)

	Teun van Eijsden
	Comment 8 • 7 years ago

I think this bug is neiher resolved nor a dupe of 1400678?
This bug is about the fact that using a ServiceWorker throws an error when the cookie setting is "Keep until I close firefox".

	Ben Kelly [:bkelly, not reviewing]
	Comment 9 • 7 years ago

The reason service workers are blocked with "keep until I close firefox" is because we don't clear them on browser exit when that setting is enabled.  Leaving storage around when the user thinks its cleared would be a privacy problem.  So this is effectively a dupe of bug 1400678 for now.  Once that is fixed we can relax the service worker permission checks to accept session storage.

	Max Stoiber (@mxstbr)
	Comment 10 • 6 years ago

bug 1400678 was resolved, so if I understand this thread correctly that means ServiceWorkers can now be installed even with the "Keep until I close Firefox" setting enabled, right?

	Ben Kelly [:bkelly, not reviewing]
	Comment 11 • 6 years ago

Its now possible to work on this bug, but some work still needs to be done to relax constraints, write tests, etc.  See bug 1413615.