Closed
Bug 1429721
Opened 7 years ago
Closed 7 years ago
Network monitor columns are shifted after adding custom one
Categories
(DevTools :: Netmonitor, defect)
Tracking
(firefox59 fixed)
RESOLVED
FIXED
Firefox 59
Tracking | Status | |
---|---|---|
firefox59 | --- | fixed |
People
(Reporter: timocov, Assigned: ntim)
References
Details
Attachments
(3 files)
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20180103231032
Steps to reproduce:
1. Open network monitor in devtools
2. Right click on table header and add new column (for example Content-Encoding)
Actual results:
Columns in the header is not aligned with columns in the table (columns are shifted).
Expected results:
Columns in the header should be aligned with columns in the table
Reporter | ||
Comment 1•7 years ago
|
||
This is screenshot network monitor in Firefox Nightly 59.0a1 (2018-01-10) (64-bit) after fix https://bugzilla.mozilla.org/show_bug.cgi?id=1360457
Reporter | ||
Updated•7 years ago
|
Component: Untriaged → Developer Tools: Netmonitor
Depends on: 1360457
Thanks Eugene for creating this bug. However, as I commented in https://bugzilla.mozilla.org/show_bug.cgi?id=1360457, this is unrelated, as the bug you are reporting was already present in versions of Nightly that were built before the bugfix for 1360457.
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → ntim.bugs
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8941796 [details]
Bug 1429721 - Ensure all netmonitor columns have a default width.
https://reviewboard.mozilla.org/r/212050/#review218026
Thanks ntim! I like the test cases cleanup. I've verified this issue get fixed properly.
::: devtools/client/netmonitor/test/head.js:693
(Diff revision 3)
> resolve(msg);
> });
> });
> }
>
> +async function testColumnsAlignment(headers, requestList) {
nit: remove async
Attachment #8941796 -
Flags: review?(rchien) → review+
Comment hidden (mozreview-request) |
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/76d24a5414eb
Ensure all netmonitor columns have a default width. r=rickychien
Comment 9•7 years ago
|
||
Backed out for devtools failure on browser_net_headers-alignment.js
Log: https://treeherder.mozilla.org/logviewer.html#?job_id=155855181&repo=autoland&lineNumber=7520
Rev: https://hg.mozilla.org/integration/autoland/rev/74e94759584cda78f2c715bbb8a5c3ab1c524e37
Flags: needinfo?(ntim.bugs)
Comment hidden (mozreview-request) |
Comment 11•7 years ago
|
||
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/1fc038162868
Ensure all netmonitor columns have a default width. r=rickychien
Assignee | ||
Updated•7 years ago
|
Flags: needinfo?(ntim.bugs)
Comment 12•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•