Closed
Bug 1429813
Opened 7 years ago
Closed 7 years ago
Drop random-if annotation for ogg-video/444-1.html reftest
Categories
(Core :: Graphics: WebRender, enhancement, P2)
Tracking
()
RESOLVED
FIXED
mozilla59
Tracking | Status | |
---|---|---|
firefox59 | --- | fixed |
People
(Reporter: kats, Assigned: kats)
References
(Blocks 1 open bug)
Details
(Whiteboard: [gfx-noted])
Attachments
(1 file)
We have a random-if annotation at [1] which we can remove after bug 1429580 lands. Hilariously, this random-if annotation actually causes the test to be *skipped* rather than treated as random, because the random-if will override the fuzzy annotation on the same line, and then the random-if will be overridden by the skip-if annotation on the parent reftest.list's include line [2]. (Without the presence of the random-if annotation, the fuzzy annotation overrides the skip-if, and so the test runs with a fuzzy expectation, and that randomly fails.)
With bug 1429580 in place, the skip-if annotation always wins, so the presence of the random-if is immaterial and so it can be removed.
[1] https://searchfox.org/mozilla-central/rev/88439dc6c5b02e167032374071cdc697a056efa1/layout/reftests/ogg-video/reftest.list#2
[2] https://searchfox.org/mozilla-central/rev/88439dc6c5b02e167032374071cdc697a056efa1/layout/reftests/reftest.list#278
Assignee | ||
Comment 1•7 years ago
|
||
err s/webm/ogg/ in the previous comment and links.
Summary: Drop random-if annotation for webm-video/444-1.html reftest → Drop random-if annotation for ogg-video/444-1.html reftest
Comment hidden (mozreview-request) |
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8941869 [details]
Bug 1429813 - Remove random-if annotation that is unnecessary now.
https://reviewboard.mozilla.org/r/212090/#review217822
Attachment #8941869 -
Flags: review?(jmuizelaar) → review+
Updated•7 years ago
|
Blocks: stage-wr-trains
Priority: -- → P2
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → bugmail
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1a764f73fb33
Remove random-if annotation that is unnecessary now. r=jrmuizel
Comment 5•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•