Closed
Bug 1429930
Opened 7 years ago
Closed 5 years ago
Add scrolling support to blob image invalidation
Categories
(Core :: Graphics: WebRender, enhancement, P2)
Core
Graphics: WebRender
Tracking
()
RESOLVED
DUPLICATE
of bug 1570081
People
(Reporter: jrmuizel, Assigned: jrmuizel)
References
Details
We need to adjust the geometries and the clips.
Updated•7 years ago
|
Assignee | ||
Comment 1•6 years ago
|
||
This should be working now. I'll confirm.
Flags: needinfo?(jmuizelaar)
Comment 2•6 years ago
|
||
I'm pretty sure this was mostly fixed by bug 1458968. But we can probably still optimize scrolling some more.
Comment 3•6 years ago
|
||
To be clear, the outstanding work on this issue is to resolve this comment: https://searchfox.org/mozilla-central/source/gfx/layers/wr/WebRenderCommandBuilder.cpp#55-58
> //XXX: problems:
> // - How do we deal with scrolling while having only a single invalidation rect?
> // We can have a valid rect and an invalid rect. As we scroll the valid rect will move
> // and the invalid rect will be the new area
Basically if an svg spans the entire screen, content being added on one side and removed on the other creates a naive invalidation rect spanning the whole screen, even though it's really two small ones on each end.
Assignee | ||
Updated•6 years ago
|
Assignee: jmuizelaar → nobody
Comment 4•6 years ago
|
||
We can't release this to the field, but we can let this ride to beta.
Priority: P1 → P2
Assignee | ||
Comment 5•6 years ago
|
||
Currently we subtract an offset from items during draw so that they end up in the right spot in the blob image. To fix this we need to move the offsetting of items from the content side to the rasterizer side. This means that our recorded items won't change their recordings as scrolling happens. This could be done by changing the blob size to a blob rect. i.e. include the offset to the origin.
WebRender also needs to make sure that it can preserve the old contents across blob image resizes and that they are shifted appropriately.
Assignee | ||
Updated•6 years ago
|
Depends on: blob-recoord
Updated•6 years ago
|
Priority: P2 → P3
Updated•6 years ago
|
Priority: P3 → P2
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → jmuizelaar
Assignee | ||
Comment 7•6 years ago
|
||
Things seem to work well enough. I think we can ship without this.
Priority: P2 → P4
Assignee | ||
Updated•6 years ago
|
Priority: P4 → P2
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 8•5 years ago
|
||
This was resolved by bug 1570081
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•