Closed
Bug 1429947
Opened 7 years ago
Closed 7 years ago
WIN64_LINK is not available in this configuration for win32 try builds
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox59 wontfix, firefox60 fixed)
RESOLVED
FIXED
mozilla60
People
(Reporter: Mardak, Assigned: chmanchester)
References
Details
Attachments
(1 file)
I see some win32 builds failing on try:
my try commit directly on top of m-c with no other changes:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d8a443e020441ceb3f3059808a39dc22c050f8b1&filter-searchStr=build-win32
jgraham has a few pushes that failed starting from the 3rd:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=cd9329a1757f60fb2876e2117441ade1f490d872&filter-searchStr=build-win32
andreio:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0720ba14775f35207fe53e7a79ceebb190d29e2e&filter-searchStr=build-win32
mak:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1b68f641ab5a15235b6f34ee16f9647fbc304f28&filter-searchStr=build-win32
Guessing it's bug 1401647 that touched "WIN64_LINK"?
Flags: needinfo?(ted)
|
Reporter | |
Comment 1•7 years ago
|
||
Sorry, I meant to say jgraham's try pushes were last successful on the 3rd:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=91062227fe1effb14384c3ce65608053f8167a68&filter-searchStr=build-win32
But started failing on the 8th:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ece9f13fdefe9ef230872293772d4bf5b689d585&filter-searchStr=build-win32
Comparing the try build log to a recent successful m-c one, the most suspicious difference is:
22:10:17 INFO - --disable-compile-environment
|
||
Comment 3•7 years ago
|
||
I thought I commented on this but apparently I never did! dmajor's analysis sounds right: this configure option is handled in toolchain.configure, which isn't loaded at all when doing artifact builds. I don't know what the best way to handle this is.
Flags: needinfo?(ted)
|
||
Comment 4•7 years ago
|
||
Do the same for WIN64_LINK as for other variables in build/mozconfig.no-compile?
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → cmanchester
| Comment hidden (mozreview-request) |
|
||
Updated•7 years ago
|
Attachment #8945951 -
Flags: review?(core-build-config-reviews) → review?(nalexander)
|
|
||
Comment 6•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8945951 [details]
Bug 1429947 - Unset WIN64_LINK and WIN64_LIB in in-tree mozconfigs during an artifact build.
https://reviewboard.mozilla.org/r/216018/#review221832
Yep.
Attachment #8945951 -
Flags: review?(nalexander) → review+
Pushed by cmanchester@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/adce260df59b
Unset WIN64_LINK and WIN64_LIB in in-tree mozconfigs during an artifact build. r=nalexander
|
||
Comment 8•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/272f337b122a
Keep build files in sync (Port bug 1429947: Unset WIN64_LINK and WIN64_LIB in in-tree mozconfigs during an artifact build). rs=bustage-fix
|
||
Updated•7 years ago
|
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
|
||
Updated•6 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•