For calling some methods of mRules from EditorBase, let's move mRules member from TextEditor to EditorBase. Unfortunately, TextEditRules.h depends on EditAction which is declared in EditorBase.h and that caused unnecessary include hell of EditorBase.h. So, let's move it to an independent header file. Review commit: https://reviewboard.mozilla.org/r/213054/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/213054/

HTMLEditRules implements only some of nsIEditActionListener and this is always first edit action listener. So, if we make EditorBase treat HTMLEditRules directly before notifying edit action listeners, we can save a lot of runtime cost (virtual calls especially unnecessary, copying array of edit action listeners with strong pointer, redundant QIs), although the code becomes not beautiful. Perhaps, we should do same thing to nsTextServicesDocument and mozInlineSpellChecker in other bugs. Review commit: https://reviewboard.mozilla.org/r/213056/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/213056/

Comment on attachment 8942838 [details] Bug 1430021 - part 2: Make HTMLEditRules not derived from nsIEditActionListener Review request updated; see interdiff: https://reviewboard.mozilla.org/r/213056/diff/1-2/

For calling some methods of mRules from EditorBase, let's move mRules member from TextEditor to EditorBase. Unfortunately, TextEditRules.h depends on EditAction which is declared in EditorBase.h and that caused unnecessary include hell of EditorBase.h. So, let's move it to an independent header file. Review commit: https://reviewboard.mozilla.org/r/213892/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/213892/

Comment on attachment 8942838 [details] Bug 1430021 - part 2: Make HTMLEditRules not derived from nsIEditActionListener Review request updated; see interdiff: https://reviewboard.mozilla.org/r/213056/diff/2-3/