Closed
Bug 1430095
Opened 7 years ago
Closed 6 years ago
Get rid of network.cookie.lifetime.enabled and network.cookie.lifetime.days prefs?
Categories
(Core :: Networking: Cookies, defect, P3)
Tracking
()
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: baku, Assigned: baku)
References
Details
(Whiteboard: [necko-triaged][killthem])
Attachments
(1 file)
(deleted),
patch
|
valentin
:
review+
|
Details | Diff | Splinter Review |
It seems to me that they are not used at all.
Assignee | ||
Updated•7 years ago
|
Flags: needinfo?(honzab.moz)
Comment 1•7 years ago
|
||
@jduell do you recall what these prefs are doing? It seems like some ancient options in about:preferences that we removed a long time ago.
Flags: needinfo?(jduell.mcbugs)
Priority: -- → P3
Whiteboard: [necko-triaged]
Comment 3•7 years ago
|
||
(In reply to Honza Bambas (:mayhemer) from comment #2)
> I'm not a cookie person, sorry.
I'm a cookie, so maybe I can help.
* network.cookie.lifetime.enabled was migrated all the way back in 2004.
Bug 233339
https://developer.mozilla.org/en-US/docs/Mozilla/Cookies_Preferences
https://dxr.mozilla.org/mozilla-release/source/extensions/cookie/nsCookiePermission.cpp#49
* network.cookie.lifetime.days
Bug 1457170 plans its removal from about:config, where it still exists and supposedly still works.
Bug 232744 is a previous failed attempt at removal.
Bug 1231319 requests it be added back to the UI.
"only used if network.cookie.lifetimePolicy is set to 3
Sets the number of days that the lifetime of cookies should be limited to."
https://developer.mozilla.org/en-US/docs/Mozilla/Cookies_Preferences$revision/38525
https://dxr.mozilla.org/mozilla-release/source/modules/libpref/init/all.js#2346
:jduell hasn't responded in 4 months. :mconnor, anything to add?
Depends on: 1457170
Flags: needinfo?(mconnor)
OS: Unspecified → All
Hardware: Unspecified → All
Whiteboard: [necko-triaged] → [necko-triaged][killthem]
Assignee | ||
Comment 4•6 years ago
|
||
Assignee: nobody → amarchesini
Attachment #8996620 -
Flags: review?(valentin.gosu)
Comment 5•6 years ago
|
||
Comment on attachment 8996620 [details] [diff] [review]
cookie_lifetime.patch
Review of attachment 8996620 [details] [diff] [review]:
-----------------------------------------------------------------
nit: update the commit message to reflect the prefs we are actually removing in this patch.
Attachment #8996620 -
Flags: review?(valentin.gosu) → review+
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fa91df9c92b7
Get rid of network.cookie.prefsMigrated, network.cookie.lifetime.enabled and network.cookie.lifetime.behavior prefs, r=valentin
Comment 7•6 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Updated•6 years ago
|
Flags: needinfo?(mconnor)
Updated•6 years ago
|
Flags: needinfo?(jduell.mcbugs)
You need to log in
before you can comment on or make changes to this bug.
Description
•