Closed
Bug 1430176
Opened 7 years ago
Closed 7 years ago
Android xpcshell logcats warn: "ActivityManager: Invalid packageName: xpcshell"
Categories
(Firefox for Android Graveyard :: Testing, enhancement, P1)
Firefox for Android Graveyard
Testing
Tracking
(firefox59 fixed)
RESOLVED
FIXED
Firefox 59
Tracking | Status | |
---|---|---|
firefox59 | --- | fixed |
People
(Reporter: gbrown, Assigned: gbrown)
References
Details
Attachments
(1 file)
(deleted),
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
It turns out there's a good reason for this and it is harmless, but I want to eliminate the warning as it can be distracting and even misleading.
Assignee | ||
Comment 1•7 years ago
|
||
For example, 149 instances in
https://public-artifacts.taskcluster.net/X7eOCceuTA6kfBU9Cqey4g/0/public/test_info//logcat-emulator-5554.log
Assignee | ||
Comment 2•7 years ago
|
||
The history is a little complicated: devicemanager's killProcess originally killed named processes, optionally using a specified signal (to allow for kill -3 or kill -6, to trigger anr and/or crash reports). With newer Android implementations, kill is sometimes not available (security issues), while force-stop is; also, force-stop may be advisable, since it may be able to perform a cleaner shutdown, reclaim resources, etc. Therefore, killProcess was updated to try using force-stop first for general process shutdown (when no signal specified), resorting to kill only when necessary. Generally, force-stop works great for Java applications, like org.mozilla.fennec; but it doesn't work, or even apply, to native applications like xpcshell, resulting in the frequent warnings seen in this bug.
The solution is simple: Allow killProcess clients to specify that the target is a native app that should be kill'ed rather than force-stop'ed.
Warnings eliminated and test jobs work fine:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=395879708bf7b28a9c4776413db31a0622549bfa
Attachment #8942297 -
Flags: review?(jmaher)
Comment 3•7 years ago
|
||
Comment on attachment 8942297 [details] [diff] [review]
in devicemanager, add 'native' param to killProcess: do not try to force-stop native apps
Review of attachment 8942297 [details] [diff] [review]:
-----------------------------------------------------------------
thanks for the explanation
Attachment #8942297 -
Flags: review?(jmaher) → review+
Pushed by gbrown@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4ed959e76522
Do not try to force-stop native android processes like xpcshell; r=jmaher
Assignee | ||
Updated•7 years ago
|
Priority: -- → P1
Comment 5•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•