Closed
Bug 1430312
Opened 7 years ago
Closed 7 years ago
Use StaticRefPtr instead of raw pointer for nsImageFrame::gIconLoad
Categories
(Core :: Layout: Images, Video, and HTML Frames, enhancement)
Core
Layout: Images, Video, and HTML Frames
Tracking
()
RESOLVED
FIXED
mozilla59
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: dholbert, Assigned: dholbert)
References
Details
Attachments
(1 file)
Where possible/easy, we should be using StaticRefPtr rather than raw pointers for reference-counted global variables & static class-variables.
Let's convert nsImageFrame::gIconLoad over. Patch coming up.
(Note: I initially also started cleaning up "sIOService" which is in some contextual code here -- but that one's a bit trickier since it's initialized via CallGetService, which we only ever seem to use with raw pointers based on a quick search. So I'm leaving that one alone for now.)
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 3•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8942379 [details]
Bug 1430312: Use StaticRefPtr instead of raw pointer for nsImageFrame::gIconLoad.
https://reviewboard.mozilla.org/r/212664/#review218388
Attachment #8942379 -
Flags: review?(tnikkel) → review+
|
||
Comment 4•7 years ago
|
||
Pushed by dholbert@mozilla.com
https://hg.mozilla.org/integration/autoland/rev/0a4e3d4de37415d0fec3f5bfb644ffa3da7eb659
Use StaticRefPtr instead of raw pointer for nsImageFrame::gIconLoad. r=tnikkel
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
|
||
Updated•6 years ago
|
Product: Core → Core Graveyard
|
|
||
Updated•6 years ago
|
Product: Core Graveyard → Core
You need to log in
before you can comment on or make changes to this bug.
Description
•