Yura Zenevich [:yzen] (please use "needinfo") Assignee
	Description • 7 years ago

At the moment we fire the event before all the components are created, destroyed. We need to change that to only fire when everything is completed. 

The reason being is that sometimes (most of the time) when we get an event and check Services.appinfo.accessibilityEnabled it is not in sync (e.g. we might not or still have a reference to an a11y service that is being created or destroyed).

	alexander :surkov (:asurkov)
	Comment 2 • 7 years ago

Comment on attachment 8942449 [details] [diff] [review]
1430412 patch

Review of attachment 8942449 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/base/nsAccessibilityService.cpp
@@ +1457,5 @@
> +
> +  if (observerService) {
> +    static const char16_t kShutdownIndicator[] = { '0', 0 };
> +    observerService->NotifyObservers(nullptr, "a11y-init-or-shutdown", kShutdownIndicator);
> +  }

usually shutdown is fired before the actual shutdown happens, so the listener has a grace period to shutdown the things properly on his end. are you sure about the change?

	Yura Zenevich [:yzen] (please use "needinfo") Assignee
	Comment 3 • 7 years ago

I think I am, yes. Having Services.appinfo.accessibilityEnabled not in sync really hurts. There is then no reliable way to know when accessibility is truly shut down.

	alexander :surkov (:asurkov)
	Comment 4 • 7 years ago

Comment on attachment 8942449 [details] [diff] [review]
1430412 patch

Review of attachment 8942449 [details] [diff] [review]:
-----------------------------------------------------------------

r=me then, afaik devtools is only one real consumer of it, and it's safe to change the behavior to whatever you want.

	Pulsebot
	Comment 5 • 7 years ago

Pushed by yura.zenevich@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5be045f0db76
fire 'a11y-init-or-shutdown' at the end of a11y service init and shutdown calls. r=surkov

	Andreea Pavel [:apavel]
	Comment 6 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/5be045f0db76