Closed
Bug 1430701
Opened 7 years ago
Closed 6 years ago
[FIX] Follow-up of bug 1413834: Handle focus navigation on frameless shadow hosts in light DOM
Categories
(Core :: DOM: Core & HTML, enhancement, P2)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: ben.tian, Assigned: smaug)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
(deleted),
patch
|
mrbkap
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
mrbkap
:
review+
|
Details | Diff | Splinter Review |
Per bug 1413834 comment 84:
"Still one problem - all contents in the host's scope are omitted as well since the frameless host doesn't appear in frame traversal.
Example: host3 in http://jsbin.com/vokafipoye/edit?html,output . Note Chrome doesn't have this problem."
Updated•7 years ago
|
Priority: -- → P2
Reporter | ||
Comment 1•7 years ago
|
||
2 options mentioned in bug 1413834 comment 97:
- traverse on DOM instead
- change shadow DOM spec
Assignee | ||
Comment 2•6 years ago
|
||
Need to do Shadow DOM skipping of frame traversal in focusmanager, so that we can find the top most host when that has display: contents.
The following patch will remove nsLightFrameIterator which has equally bad parent tree traversal. Luckily sequential focusing isn't hot code.
Assignee: nobody → bugs
Attachment #8992193 -
Flags: review?(mrbkap)
Assignee | ||
Comment 3•6 years ago
|
||
nsLightFrameIterator is now unused
remote: View your changes here:
remote: https://hg.mozilla.org/try/rev/d4a61814283edf4dd8cf1c33b88eed7681a7c74d
remote: https://hg.mozilla.org/try/rev/de2c13ddf7ea2d5e5943651c18d1d6d3c2cc3fb6
remote:
remote: Follow the progress of your build on Treeherder:
remote: https://treeherder.mozilla.org/#/jobs?repo=try&revision=de2c13ddf7ea2d5e5943651c18d1d6d3c2cc3fb6
remote: recorded changegroup in replication log in 0.054s
Attachment #8992194 -
Flags: review?(mrbkap)
Assignee | ||
Updated•6 years ago
|
Summary: Follow-up of bug 1413834: Handle focus navigation on frameless shadow hosts in light DOM → [FIX] Follow-up of bug 1413834: Handle focus navigation on frameless shadow hosts in light DOM
Comment 4•6 years ago
|
||
Comment on attachment 8992193 [details] [diff] [review]
shadow_display_contents_tabbing.diff
Review of attachment 8992193 [details] [diff] [review]:
-----------------------------------------------------------------
Sorry for the delay. I had to go re-read the method in full to understand the context of what we're trying to do with this code.
Attachment #8992193 -
Flags: review?(mrbkap) → review+
Updated•6 years ago
|
Attachment #8992194 -
Flags: review?(mrbkap) → review+
Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b2bf59373df2
contents of frameless shadow hosts should be focusable, r=mrbkap
https://hg.mozilla.org/integration/mozilla-inbound/rev/b13a396d28ec
remove now unused nsLightFrameIterator, r=mrbkap
Comment 6•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b2bf59373df2
https://hg.mozilla.org/mozilla-central/rev/b13a396d28ec
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•