Closed Bug 1430785 Opened 7 years ago Closed 7 years ago

Make mozInlineSpellChecker not derived from nsIEditActionListener

Categories

(Core :: DOM: Editor, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox59 --- wontfix
firefox60 --- fixed

People

(Reporter: masayuki, Assigned: masayuki)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

EditorBase::mInlineSpellChecker is always an instance of mozInlineSpellChecker since EditorBase::GetInlineSpellChecker() always creates it via CID. https://searchfox.org/mozilla-central/rev/41925c0b6c6d58578690121de439d2a8d3d690f3/editor/libeditor/EditorBase.cpp#1347,1368 Additionally, looks like that mozInlineSpellChecker.h can be exposed. So, we can make EditorBase directly stores mozInlineSpellChecker and calls only necessary edit action listener methods directly.
Comment on attachment 8943884 [details] Bug 1430785 - Make mozInlineSpellChecker not derived from nsIEditActionListener https://reviewboard.mozilla.org/r/214242/#review220102
Attachment #8943884 - Flags: review?(m_kato) → review+
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/f0d1a3a8ecef Make mozInlineSpellChecker not derived from nsIEditActionListener r=m_kato
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Depends on: 1439435
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: