nsTextServicesDocument stores editor with nsWeakPtr for avoiding circular reference. However, both TextEditor and nsTextServicesDocument are cycle collectable. So, we don't need to worry about the issue and we can simply make it store with RefPtr<TextEditor>. Then, we can make EditorBase and nsTextServicesDocument access each other directly. Review commit: https://reviewboard.mozilla.org/r/214078/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/214078/

For making nsTextServicesDocument accessible from anywhere directly, we need to expose its header. Then, it should be in mozilla namespace. This patch renames nsTextServicesDocument to mozilla::TextServicesDocument and expose the header file as "mozilla/TextServicesDocument.h". Review commit: https://reviewboard.mozilla.org/r/214080/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/214080/

Now, TextServicesDocument can be treated by anybody. So, let's make mozSpellChecker and nsEditorSpellChecker treat it directly instead of nsITextServicesDocument. Review commit: https://reviewboard.mozilla.org/r/214082/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/214082/

nsITextServicesDocument isn't used by anybody now. So, we can get rid of it. Additionally, nsITextService and nsTextServicesFactory are not also used by anybody. Therefore, this patch removes all of them. Review commit: https://reviewboard.mozilla.org/r/214084/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/214084/

nsEditorSpellCheck::mSpellChecker is always mozSpellChecker because it's created only by nsEditorSpellCheck. Additionally, mozSpellChecker.h is already exposed. So, nsEditorSpellCheck can store it as mozSpellChecker directly. Review commit: https://reviewboard.mozilla.org/r/214086/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/214086/

For making mozInlineSpellChecker stores nsEditorSpellCheck directly, we need to expose its header file. For doing that this patch renames the class to mozilla::EditorSpellCheck and expose it as "mozilla/EditorSpellCheck.h". Review commit: https://reviewboard.mozilla.org/r/214088/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/214088/

mozInlienSpellChecker::mSpellCheck and mozInlineSpellChecker::mPendingSpellCheck are always instances of EditorSpellCheck because mozInlienSpellChecker creates its instance. Therefore, making mozInlineSpellChecker store EditorSpellCheck directly makes sense. Review commit: https://reviewboard.mozilla.org/r/214090/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/214090/

EditorBase::mInlineSpellChecker is always an instance of mozInlineSpellChecker. Fortunately, it's easy to expose mozInlineSpellChecker.h. So, making EditorBase store it as mozInlineSpellChecker directly, EditorBase can access any of mozInlineSpellChecker, EditorSpellCheck, mozSpellChecker and TextServicesDocument with new accessors created by following patch. Review commit: https://reviewboard.mozilla.org/r/214092/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/214092/

mozSpellChecker stores TextServicesDocument, EditorSpellCheck stores mozSpellChecker and mozInlineSpellChecker stores EditorSpellCheck. So, they should have accessors for their member. Then, EditorBase can access all of them. Review commit: https://reviewboard.mozilla.org/r/214094/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/214094/

Currently, first edit action listener is always TextServicesDocument for EditorBase::mInlineSpellChecker if spell check is enabled and it requires only DidDeleteNode() and DidJoinNodes(). So, in most cases, EditorBase should call only them to avoid running redundant for loops for nsIEditActionListener methods. This patch makes that EditorBase::AddEditActionListener() and RemoveEditActionListener() check whether coming nsIEditActionListener is TextServicesDocument for mInlineSpellChecker. If so, EditorBase should store it as reference to TextServicesDocument. And when edit action occurs, its DidDeleteNode() and DidJoinNodes() should be called directly. Unfortunately, this patch makes TextServiceDocument's maintaining rules complicated. However, it must be really rare case to add new edit action listener because it's really old component. Note that EditorSpellCheck may be created multiple instances for an editor from chrome JS. Therefore, we need to keep TextServicesDocument being derived from nsIEditActionListener because in such case, TextServicesDocument for other EditorSpellCheck instances should be supported via nsIEditActionListener even though such case makes EditorBase slower. Review commit: https://reviewboard.mozilla.org/r/214096/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/214096/