Andrew McCreight [:mccr8] Assignee
	Description • 7 years ago

ReleaseData is a generic function used to destroy string data. I'll add it to the prefix list to split up the different call sites into different signatures.

Here's an example of a crash report with the most common protosignature with this signature (making up 46% of the total crashes):
  bp-cac1d6a0-ed50-4959-a431-321c10180117

After this change, I think the signature will be more like:
  ReleaseData | nsTArray_Impl<T>::DestructRange | nsTArray_Impl<T>::ReplaceElementsAt<T> | mozilla::net::nsHttpRequestHead::SetHeaders

	Andrew McCreight [:mccr8] Assignee
	Comment 1 • 7 years ago

https://github.com/mozilla-services/socorro/pull/4296

	[github robot]
	Comment 2 • 7 years ago

Commits pushed to master at https://github.com/mozilla-services/socorro

https://github.com/mozilla-services/socorro/commit/96919c4505c9074d7fe86985902a47a2cd7ebcc7
Bug 1431167 - Add ReleaseData to the prefix list

ReleaseData is a generic function used to destroy string data.

https://github.com/mozilla-services/socorro/commit/9f7b7ce4b50895c89da12165ff0e24ca9859daa5
Merge pull request #4296 from amccreight/patch-14

Bug 1431167 - Add ReleaseData to the prefix list

	Will Kahn-Greene [:willkg] ET needinfo? me
	Comment 3 • 7 years ago

Andrew: There are 3500 or so crash reports with this signature. When this goes to -prod, would you want me to reprocess them?

	Andrew McCreight [:mccr8] Assignee
	Comment 4 • 7 years ago

(In reply to Will Kahn-Greene [:willkg] ET needinfo? me from comment #3)
> Andrew: There are 3500 or so crash reports with this signature. When this
> goes to -prod, would you want me to reprocess them?

I don't think it matters too much. The related crash doesn't seem to be very high priority.

	Will Kahn-Greene [:willkg] ET needinfo? me
	Comment 5 • 7 years ago

Ok. IF that ever changes, we can always reprocess later.

This is fixed now in master branch, so I'm going to mark it FIXED. It should go out in the next deploy today or tomorrow.