Closed Bug 1431433 Opened 7 years ago Closed 7 years ago

Android emulator test configuration could be tidier

Categories

(Firefox for Android Graveyard :: Testing, enhancement, P1)

enhancement

Tracking

(firefox59 fixed)

RESOLVED FIXED
Firefox 59
Tracking Status
firefox59 --- fixed

People

(Reporter: gbrown, Assigned: gbrown)

References

Details

Attachments

(4 files)

      No description provided.
Comment on attachment 8943647 [details] [diff] [review]
split out common configuration, remove obsolete features

Review of attachment 8943647 [details] [diff] [review]:
-----------------------------------------------------------------

nice!
Attachment #8943647 - Flags: review?(jmaher) → review+
Pushed by gbrown@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f5b90dd89e1a
Tidy and reorganize mozharness configuration for Android emulator tests; r=jmaher
Keywords: leave-open
Blocks: 1425322
Keywords: leave-open
Left over from buildbot days!
Attachment #8943811 - Flags: review?(jmaher)
The default ports are slightly different, but work just as well!
Attachment #8943812 - Flags: review?(jmaher)
Attached patch miscellaneous tidying (deleted) — Splinter Review
Last few things that were bugging me - that's all for now!
Attachment #8943814 - Flags: review?(jmaher)
All patches applied and everything working just the same:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6e61f498b2e5ac155cb085653cbdf743ec9ab312
Comment on attachment 8943811 [details] [diff] [review]
remove support for reftest-debug, crashtest-debug, jsreftest-debug suites

Review of attachment 8943811 [details] [diff] [review]:
-----------------------------------------------------------------

very cool!
Attachment #8943811 - Flags: review?(jmaher) → review+
Comment on attachment 8943812 [details] [diff] [review]
remove ssl-port, http-port configuration

Review of attachment 8943812 [details] [diff] [review]:
-----------------------------------------------------------------

do we need to consider the case of autophone?
Attachment #8943812 - Flags: review?(jmaher) → review+
Comment on attachment 8943814 [details] [diff] [review]
miscellaneous tidying

Review of attachment 8943814 [details] [diff] [review]:
-----------------------------------------------------------------

looking good
Attachment #8943814 - Flags: review?(jmaher) → review+
(In reply to Joel Maher ( :jmaher) (UTC-5) from comment #10)
> do we need to consider the case of autophone?

I checked with :bc -- it's okay.
Priority: -- → P1
Pushed by gbrown@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8a4dcd3475e0
Cleanup support for obsolete -debug Android test suites; r=jmaher
https://hg.mozilla.org/integration/mozilla-inbound/rev/56917373186f
Remove ssl_port/http_port from Android mozharness configs; r=jmaher
https://hg.mozilla.org/integration/mozilla-inbound/rev/84f55fec8d39
Miscellaneous simplifications to android_emulator_unittest.py; r=jmaher
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: