Closed Bug 1431457 Opened 7 years ago Closed 7 years ago

Upgrade Netmonitor to the latest Launchpad version

Categories

(DevTools :: Netmonitor, enhancement, P1)

enhancement

Tracking

(firefox60 fixed)

RESOLVED FIXED
Firefox 60
Tracking Status
firefox60 --- fixed

People

(Reporter: Honza, Assigned: Honza)

References

Details

Attachments

(1 file)

Net monitor is using old version of the Launchpad, which doesn't work (running `yarn start` produces many exceptions). We need to: 1) upgrade 2) fix all exceptions. Honza
Assignee: nobody → odvarko
Status: NEW → ASSIGNED
Priority: -- → P1
The issue with StackTrace side panel has been fixed here: https://github.com/devtools-html/devtools-core/pull/906 The issue with icons is reported as bug 1431773 I don't know how exactly we should fix the icons and it looks like some discussion is needed, so let's not block this patch, which at least allows running the Netmonitor on top of the Launchpad. Honza
(In reply to Jan Honza Odvarko [:Honza] from comment #2) > The issue with StackTrace side panel has been fixed here: > https://github.com/devtools-html/devtools-core/pull/906 You would need to release a new version of devtools-connection, and update package.json from whatever project is using it, may be launchpad?
Comment on attachment 8944000 [details] Bug 1431457 - Upgrade Netmonitor to the latest Launchpad version; https://reviewboard.mozilla.org/r/214328/#review220162 I'm not really used to npm dependencies, so I don't know how explicit we should be in deps definitions. Otherwise, have you seen that the background of filter box is dark grey? ::: devtools/client/netmonitor/.babelrc:16 (Diff revision 1) > + { > + "alias": { > + "devtools/client/shared/vendor/react": "react", > + "devtools/client/shared/vendor/react-dom": "react-dom" > + } > + } Do we really need: syntax-trailing-function-commas transform-class-properties module-resolver ? If we need them, what failed without this? ::: devtools/client/netmonitor/package.json:14 (Diff revision 1) > + "babel-core": "6.26.0", > + "babel-plugin-syntax-trailing-function-commas": "^6.22.0", > + "babel-plugin-transform-class-properties": "^6.24.1", > + "babel-plugin-transform-flow-strip-types": "^6.22.0", > + "babel-plugin-transform-react-jsx": "^6.24.1", > + "babel-preset-env": "^1.6.1", Do we have to specific more than the plugins we are using? (i.e. do we have to list babel-core/babel-preset-env)
Attachment #8944000 - Flags: review?(poirot.alex) → review+
(In reply to Alexandre Poirot [:ochameau] from comment #4) > Do we really need: > syntax-trailing-function-commas > transform-class-properties > module-resolver > Do we have to specific more than the plugins we are using? (i.e. do we have > to list babel-core/babel-preset-env) I copied those from the Console, but they are not necessary, removed. Thanks, Honza
Pushed by jodvarko@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d5225b5997c3 Upgrade Netmonitor to the latest Launchpad version; r=ochameau
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: