Closed Bug 1431879 Opened 7 years ago Closed 7 years ago

Generate json config and moz.build files for GN projects deterministically

Categories

(Firefox Build System :: General, enhancement)

Product:
Firefox Build System
Component:
General
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(firefox60 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla60
Tracking Flags:
Tracking Status
firefox60 --- fixed

People

(Reporter: chmanchester, Assigned: chmanchester)

References

Details

Attachments

(1 file)

Bug 1431879 - Use sorted iterators when generating moz.build files from gn to make the output deterministic.
(deleted), text/x-review-board-request
froydnj
: review+
froydnj
: review+
Details
Re-generating things creates huge diffs, we should generate both the config files and moz.build files deterministically.
Assignee: nobody → cmanchester
I think the configs are already being generated deterministically, but I have a patch for the moz.builds.
Comment on attachment 8944981 [details] Bug 1431879 - Use sorted iterators when generating moz.build files from gn to make the output deterministic. https://reviewboard.mozilla.org/r/215136/#review220838
Attachment #8944981 - Flags: review+
Attachment #8944981 - Flags: review?(core-build-config-reviews) → review+
Pushed by cmanchester@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/781a2e1af4a8 Use sorted iterators when generating moz.build files from gn to make the output deterministic. r=froydnj
https://hg.mozilla.org/mozilla-central/rev/781a2e1af4a8
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox60: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Product: Core → Firefox Build System
Blocks: 1466254
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: