Closed
Bug 1431965
Opened 7 years ago
Closed 7 years ago
Stop using nsIDOMAttr in JS code
Categories
(Calendar :: General, enhancement)
Calendar
General
Tracking
(Not tracked)
RESOLVED
FIXED
6.1
People
(Reporter: bzbarsky, Assigned: mschroeder)
References
Details
Attachments
(1 file)
(deleted),
patch
|
Fallen
:
review+
Fallen
:
approval-calendar-beta+
|
Details | Diff | Splinter Review |
I plan to remove nsIDOMAttr in bug 1431964.
Calendar uses it in two places in calendar/base/modules/calXMLUtils.jsm, both times as:
next instanceof Components.interfaces.nsIDOMAttr
You should be able to replace those with:
ChromeUtils.getClassName(next) == "Attr"
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → mschroeder
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•7 years ago
|
||
This is a potential, but untested patch for the issue raised.
Assignee | ||
Updated•7 years ago
|
Attachment #8944246 -
Flags: review?(philipp)
Comment 2•7 years ago
|
||
Philipp, can you get to the review here, since bug 1431964 has been landed for 59 already, so we would need this patch for fully a working calendar view in the upcoming beta.
Comment 3•7 years ago
|
||
Comment on attachment 8944246 [details] [diff] [review]
Patch v1
Review of attachment 8944246 [details] [diff] [review]:
-----------------------------------------------------------------
Yep, sorry for the delay. Tested this in the browser console and it seems to work fine for attributes. r=philipp
Attachment #8944246 -
Flags: review?(philipp)
Attachment #8944246 -
Flags: review+
Attachment #8944246 -
Flags: approval-calendar-beta+
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/598844f28f16
Stop using nsIDOMAttr in JS code. r=philipp
Updated•7 years ago
|
Target Milestone: --- → 6.2
Comment 5•7 years ago
|
||
Beta (TB 59, Calendar 6.1):
https://hg.mozilla.org/releases/comm-beta/rev/0607b098d13f0ede293b6732f562d5b3f887bab6
Target Milestone: 6.2 → 6.1
You need to log in
before you can comment on or make changes to this bug.
Description
•