Closed
Bug 1432231
Opened 7 years ago
Closed 7 years ago
Update compare-locales in elmo webapp to include python-fluent 0.6
Categories
(Webtools Graveyard :: Elmo, enhancement)
Webtools Graveyard
Elmo
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Pike, Assigned: Pike)
References
Details
When we get python-fluent 0.6 ready and in compare-locales, we need to pick that up in elmo for the diff view.
Not sure if there's actually something to change in the diff view for the syntax updates. We didn't support tags yet at all.
Stas? https://github.com/mozilla/elmo/blob/7dfebad36aef5fd9d884993c1f95969744c30f46/apps/pushes/views/diff.py#L262-L266 is the fluent-specific part of the diff view right now.
Flags: needinfo?(stas)
Comment 1•7 years ago
|
||
We should only show attributes if the id is a public one, i.e. doesn't start with a dash.
Flags: needinfo?(stas)
Assignee | ||
Comment 2•7 years ago
|
||
Actually, I think flod would be interested in seeing if entities add or remove attributes on private messages for sign-off.
Comment 3•7 years ago
|
||
(In reply to Axel Hecht [:Pike] from comment #2)
> Actually, I think flod would be interested in seeing if entities add or
> remove attributes on private messages for sign-off.
I definitely need to see all changes happening to the file, that includes private IDs.
Comment 4•7 years ago
|
||
Good point. I can't think of any other changes required but let me check again after I've updated compare-locales to python-fluent 0.6.
Updated•7 years ago
|
Comment 5•7 years ago
|
||
Commit pushed to develop at https://github.com/mozilla/elmo
https://github.com/mozilla/elmo/commit/a1d0fef218cc094d1f574eedf3052a279975c107
bug 1432231, update fluent to 0.6.x, and compare-locales
Assignee | ||
Comment 6•7 years ago
|
||
Fixed and deployed.
Assignee: nobody → l10n
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Updated•4 years ago
|
Product: Webtools → Webtools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•