Closed
Bug 1432657
Opened 7 years ago
Closed 7 years ago
Add pocket card type to highlight types
Categories
(Firefox :: New Tab Page, enhancement, P1)
Firefox
New Tab Page
Tracking
()
Tracking | Status | |
---|---|---|
firefox60 | --- | verified |
People
(Reporter: Mardak, Assigned: ursula)
References
(Blocks 1 open bug)
Details
(Whiteboard: [strings landed][AS60MVP] )
Attachments
(1 file)
(deleted),
text/x-github-pull-request
|
Details |
No description provided.
Updated•7 years ago
|
Whiteboard: [AS60MVP]
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → usarracini
Assignee | ||
Updated•7 years ago
|
Priority: P2 → P1
Comment 1•7 years ago
|
||
Updated•7 years ago
|
Iteration: 60.2 - Feb 12 → 60.3 - Feb 26
Reporter | ||
Updated•7 years ago
|
Whiteboard: [AS60MVP] → [strings needed][AS60MVP]
Reporter | ||
Comment 2•7 years ago
|
||
uiwanted: What's the behavior of saving to pocket? Should the doorhanger appear just like bookmarking? What should the card type text be as well as the context menu options for saving/removing? (We'll check with pocket people too.)
Keywords: uiwanted
Comment 3•7 years ago
|
||
Trello card with InVision spec: https://trello.com/c/sC5SB5mK/179-pocket-saves-in-highlights
Comment 4•7 years ago
|
||
Commits pushed to master at https://github.com/mozilla/activity-stream
https://github.com/mozilla/activity-stream/commit/5b5fb32674da9e96aa9267d1c021c6300057e0a1
Bug 1432657 - Add pocket card type to highlight types
https://github.com/mozilla/activity-stream/commit/b033185d8e890938765552d94621e1ba08758989
Merge pull request #3975 from sarracini/bug_1432657
Fix Bug 1432657 - Add pocket card type to highlight types
Updated•7 years ago
|
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 5•7 years ago
|
||
Target Milestone: --- → Firefox 60
Comment 6•7 years ago
|
||
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0
Firefox: 60.0a1, Build ID 20180226230123
I have verified this on Windows 10 x64, Ubuntu 14.04 x64 and Mac 10.12 with the latest Nightly build (60.0a1) installed. Now after a card is saved to Pocket the "Archive in Pocket" and the "Delete from Pocket" options are displayed in the card's context menu and also the "Bookmark" and "Delete from History" options are removed from it.
Also, if a website is saved to pocket by any means, it will be displayed as a card in the Highlights section with the "Saved to Pocket" subtext.
Status: RESOLVED → VERIFIED
Reporter | ||
Comment 7•7 years ago
|
||
Strings landed for localization in https://github.com/mozilla/activity-stream-l10n/pull/11
Whiteboard: [strings needed][AS60MVP] → [strings landed][AS60MVP]
Updated•5 years ago
|
Component: Activity Streams: Newtab → New Tab Page
You need to log in
before you can comment on or make changes to this bug.
Description
•