Pick commits: 4c18a84 (HEAD -> master, upstream/master, upstream/HEAD, origin/master) Explicitly init stream_params.prefs in tests. 3baab54 WASAPI: Explain why we don't check AUDCLNT_BUFFERFLAGS_DATA_DISCONTINUITY a0491a0 WASAPI: Hide loopback dummy output from data callback. 0986399 Update loopback test to check that output is not passed in data callback 4945f4a Non-wasapi backends return errors if loopback is requested. 9e28c42 Respond to review comments. 41221a2 Add loopback test where devices are explicitly selected via device id. 701178c Add test for loopback when playback is silent 2bb275d Add further test for separate loopback and playback streams. 3f5966c Add loopback test file and test for duplex stream with loopback. ae7120d Use duplex to drive loopback, even if no output is requested. 2577549 WASAPI: Modify setup_wasapi_stream_one_side so a loopback device can be obtained. 0a15b9e Add stream preferences enum to stream params, add a loopback pref. 94d1c0d Rework get_input_buffer to better function with pull based streams and remove cruft. 2b98e3d Add assertion to make sure output params are present for winmm_stream_init. ed3ded8 Don't enumerate private aggregate devices in cubeb_audiounit.cpp (#400) 550c96f wasapi: increase initial silence on debug 6c45dde Fix issue 378: Pass through as more data as possible when upmixing 2d798bd WASAPI: Check that the input side of a stream was successfully setup before pushing silence. 83a9740 pulse: avoid deadlock when context subscribe fails fc83d6f cubeb_resampler_speex: don't call data callback while draining (#398) fe643a4 Replace free by delete to prevent potential memory leak a0d259a jack: expect null pointer from jack_get_ports (Bug 1422664)

Please add your bug as blocked by this one.

Hmm this does not work well. We need to update the cubeb-rs and cubeb-pulse-rs with the new pref in stream params in order to make that import. We also need to update gecko where stream params are set adding the new pref. Bryce can you do that?

Also have some local commits that update our usage of the prefs, as well as add the new tests from cubeb. I can push them against this bug once I've got the rust stuff sorted.

It's not necessary, I will use this bug to import up to commit 2b98e3d and we can handle the rest when you are ready in a new bug. Thanks for doing that.

Pick commits: 2b98e3d Add assertion to make sure output params are present for winmm_stream_init. ed3ded8 Don't enumerate private aggregate devices in cubeb_audiounit.cpp (#400) 550c96f wasapi: increase initial silence on debug 6c45dde Fix issue 378: Pass through as more data as possible when upmixing 2d798bd WASAPI: Check that the input side of a stream was successfully setup before pushing silence. 83a9740 pulse: avoid deadlock when context subscribe fails fc83d6f cubeb_resampler_speex: don't call data callback while draining (#398) fe643a4 Replace free by delete to prevent potential memory leak a0d259a jack: expect null pointer from jack_get_ports (Bug 1422664)

Comment on attachment 8945100 [details] Bug 1432733 - Update cubeb from upstream to 2b98e3d. https://reviewboard.mozilla.org/r/215322/#review220998

Pushed by achronop@gmail.com: https://hg.mozilla.org/integration/autoland/rev/590643620ec4 Update cubeb from upstream to 2b98e3d. r=padenot

Bug 1432869 created to track bringing across the rest of the originally planned commits.